Re: Logging in LockBufferForCleanup()

2022-02-10 Thread Fujii Masao
On 2022/02/10 20:28, Masahiko Sawada wrote: While I understand that these are theoretically valid concerns, it’s unclear to me how much the current code leads to bad effects in practice. There are other low-level codes/paths that call palloc() while holding LWLocks, and I’m not sure that the o

Re: Logging in LockBufferForCleanup()

2022-02-10 Thread Masahiko Sawada
On Thu, Feb 10, 2022 at 11:22 AM Andres Freund wrote: > > Hi, > > I just noticed somewhat new code in LockBufferForCleanup(), added in > > commit 39b03690b529935a3c33024ee68f08e2d347cf4f > Author: Fujii Masao > Date: 2021-01-13 22:59:17 +0900 > > Log long wait time on recovery conflict when

Re: Logging in LockBufferForCleanup()

2022-02-09 Thread Michael Paquier
On Wed, Feb 09, 2022 at 06:22:05PM -0800, Andres Freund wrote: > Previously the code looked somewhat safe to use in critical section like > blocks (although whether it'd be good idea to use in one is a different > question), but not after. Even if not used in a critical section, adding new > failur

Logging in LockBufferForCleanup()

2022-02-09 Thread Andres Freund
Hi, I just noticed somewhat new code in LockBufferForCleanup(), added in commit 39b03690b529935a3c33024ee68f08e2d347cf4f Author: Fujii Masao Date: 2021-01-13 22:59:17 +0900 Log long wait time on recovery conflict when it's resolved. commit 64638ccba3a659d8b8a3a4bc5b47307685a64a8a Author