Re: Log query parameters for terminated execute

2018-07-26 Thread Sergei Kornilov
Hello > Changed the status as per last email of Tom Lane. I have no idea what can i change. I received no feedback how i can print parameters in other cases. Should i mark CF as rejected? regards, Sergei

Re: Log query parameters for terminated execute

2018-07-26 Thread Ibrar Ahmed
Changed the status as per last email of Tom Lane.

Re: Log query parameters for terminated execute

2018-07-23 Thread Sergei Kornilov
Hello 23.07.2018, 17:08, "Tom Lane" : > Sergei Kornilov writes: >>  Please test with logging command tag %i in log_line_prefix. Extended >> protocol has three different messages, each can be canceled by timeout. But >> here is completely no parameters in PARSE and i did not change BIND in first

Re: Log query parameters for terminated execute

2018-07-23 Thread Tom Lane
Sergei Kornilov writes: > Please test with logging command tag %i in log_line_prefix. Extended protocol > has three different messages, each can be canceled by timeout. But here is > completely no parameters in PARSE and i did not change BIND in first patch. This patch scares me to death. It r

Re: Log query parameters for terminated execute

2018-07-23 Thread Sergei Kornilov
Hello! >> After shutdown signal we must be in aborted state, so we mustn't call >> user-defined I/O functions. (quotation from comment to errdetail_params in >> src/backend/tcop/postgres.c ). It seems i can not fix it with current design. > > No its not about calling the function after abort/shu

Re: Log query parameters for terminated execute

2018-07-23 Thread Ibrar Ahmed
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested Review submitted The new status of this patch is: Waiting on Author

Re: Log query parameters for terminated execute

2018-07-23 Thread Ibrar Ahmed
On Mon, Jul 23, 2018 at 3:05 PM, Sergei Kornilov wrote: > Hello > Thank you for review! > Well, i can miss some cases. I'm not sure about overall design of this > patch. Is acceptable add errdetail_params to statement_timeout ereport in > such way? > > After shutdown signal we must be in aborted

Re: Log query parameters for terminated execute

2018-07-23 Thread Sergei Kornilov
Hello Thank you for review! Well, i can miss some cases. I'm not sure about overall design of this patch. Is acceptable add errdetail_params to statement_timeout ereport in such way? After shutdown signal we must be in aborted state, so we mustn't call user-defined I/O functions. (quotation from

Re: Log query parameters for terminated execute

2018-07-23 Thread Ibrar Ahmed
On Sun, Jun 24, 2018 at 1:08 AM, Pavel Stehule wrote: > > > 2018-06-23 21:54 GMT+02:00 Sergei Kornilov : > >> Hello all >> We already have feature to logging query parameters. If we use >> log_statement = 'all' we write parameters before execution and all is fine >> here. If we use log_min_durati

Re: Log query parameters for terminated execute

2018-06-23 Thread Pavel Stehule
2018-06-23 21:54 GMT+02:00 Sergei Kornilov : > Hello all > We already have feature to logging query parameters. If we use > log_statement = 'all' we write parameters before execution and all is fine > here. If we use log_min_duration_statement statement is logged obviously > after execution, but c

Log query parameters for terminated execute

2018-06-23 Thread Sergei Kornilov
Hello all We already have feature to logging query parameters. If we use log_statement = 'all' we write parameters before execution and all is fine here. If we use log_min_duration_statement statement is logged obviously after execution, but currently we have no parameters if query was terminate