On 29/08/2024 04:06, Alvaro Herrera wrote:
I have had many a chance to visit english.stackexchange.net on
account of something I read in pgsql lists or code comments.
I see what you did there :-).
Committed, with "which see". Thanks everyone!
--
Heikki Linnakangas
Neon (https://neon.tech)
On 2024-Aug-28, Tom Lane wrote:
> Heikki Linnakangas writes:
> > Hmm, I don't see the issue. It's an uncommon sentence structure, but it
> > was there before this patch, and it's correct AFAICS. If you grep for
> > "which see ", you'll find some more examples of that.
>
> I didn't check the g
On Wed, Aug 28, 2024 at 2:41 PM Andreas Karlsson wrote:
> Not sure if it is correct or not but from some googling it seems to be a
> direct translation of "quod vide". I think "for which, see" would likely
> be more proper English but it is not my native language and we use
> "which see" elsewhere
Heikki Linnakangas writes:
> On 28/08/2024 18:26, Andreas Karlsson wrote:
>> Small typo with the extra "which" which makes the sentence not flow
>> correctly
>> "This is called from CreateSharedMemoryAndSemaphores(), which see for
>> more comments."
> Hmm, I don't see the issue. It's an uncommon
On 8/28/24 7:26 PM, Heikki Linnakangas wrote:
Hmm, I don't see the issue. It's an uncommon sentence structure, but it
was there before this patch, and it's correct AFAICS. If you grep for
"which see ", you'll find some more examples of that.
Not sure if it is correct or not but from some googl
On 28/08/2024 18:26, Andreas Karlsson wrote:
On 8/7/24 2:08 PM, Heikki Linnakangas wrote:
The attached patches rename them to follow the usual naming convention.
The InitLocks() function is refactored a bit more, splitting the
per-backend initialization to a separate InitLockManagerAccess()
func
On 8/7/24 2:08 PM, Heikki Linnakangas wrote:
The attached patches rename them to follow the usual naming convention.
The InitLocks() function is refactored a bit more, splitting the
per-backend initialization to a separate InitLockManagerAccess()
function. That's why it's in a separate commit.
It's bothered me for a long time that some of the shmem initialization
functions have non-standard names. Most of them are called
FoobarShmemSize() and FoobarShmemInit(), but there are a few exceptions:
InitBufferPool
InitLocks
InitPredicateLocks
CreateSharedProcArray
CreateSharedBackendStatus
