Hello.
At Tue, 10 Jul 2018 18:52:54 +0200, Peter Eisentraut
wrote in
> committed
Thank you for committing this!
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
committed
On 10.07.18 08:49, Kyotaro HORIGUCHI wrote:
> Thank you for the notice.
>
> At Mon, 9 Jul 2018 12:30:22 +0300, Arthur Zakirov
> wrote in <20180709093021.GA9309@zakirov.localdomain>
>> Hello,
>>
>> On Mon, Jul 09, 2018 at 06:07:24PM +0900, Kyotaro HORIGUCHI wrote:
>>> The new version v
Thank you for the notice.
At Mon, 9 Jul 2018 12:30:22 +0300, Arthur Zakirov
wrote in <20180709093021.GA9309@zakirov.localdomain>
> Hello,
>
> On Mon, Jul 09, 2018 at 06:07:24PM +0900, Kyotaro HORIGUCHI wrote:
> > The new version v4 is changed in the following points.
> >
> > - Don't renumber t
Hello,
On Mon, Jul 09, 2018 at 06:07:24PM +0900, Kyotaro HORIGUCHI wrote:
> The new version v4 is changed in the following points.
>
> - Don't renumber the DSM_IMPL symbols, just removed _NONE.
>
> - Rewrote the pointed comment.
>
> - Revised the commit message removing a mention to an
> alre
At Mon, 9 Jul 2018 10:49:19 +0900, Michael Paquier wrote
in <20180709014919.gh1...@paquier.xyz>
> On Fri, Jul 06, 2018 at 11:08:02PM +0200, Peter Eisentraut wrote:
> > On 26.06.18 09:10, Kyotaro HORIGUCHI wrote:
> > I would avoid renumbering here. It was kind of sensible to have NONE =
> > 0, so
On Fri, Jul 06, 2018 at 11:08:02PM +0200, Peter Eisentraut wrote:
> On 26.06.18 09:10, Kyotaro HORIGUCHI wrote:
>> --- a/src/include/storage/dsm_impl.h
>> +++ b/src/include/storage/dsm_impl.h
>> @@ -14,11 +14,10 @@
>> #define DSM_IMPL_H
>>
>> /* Dynamic shared memory implementations. */
>> -#de
On 26.06.18 09:10, Kyotaro HORIGUCHI wrote:
> --- a/src/bin/initdb/initdb.c
> +++ b/src/bin/initdb/initdb.c
> @@ -984,6 +984,16 @@ test_config_settings(void)
> ok_buffers = 0;
>
>
> + /*
> + * Server doesn't confirm that the server-default DSM implementati
Hello.
# Subject is fixed.
I think this kind of thing is sutable for doing at the beginning
of a dev cycle.
Since it has been a long time since DSM was introduced and it is
turned on by default and I believe no one turns it off on
purpose. I'd like to propose to get rid of the choice of none.
T
