On Mon, Jan 16, 2023 at 10:52:43AM +0900, Kyotaro Horiguchi wrote:
> Yeah, we could do that. But as I mentioned before, that happens only
> on startup thus it can be said that that's not worth bothering. On
> the other hand I don't think it's great to waste 16kB * max_backends
> memory especially
At Thu, 12 Jan 2023 15:02:25 +0530, Bharath Rupireddy
wrote in
> On the contrary, PGAlignedBlock is being used elsewhere in the code;
I noticed it and had the same feeling, and thought that they don't
justify to do the same at other places.
> some of them are hot paths. verifyBackupPageConsist
On Thu, Jan 12, 2023 at 04:37:38PM +0800, Julien Rouhaud wrote:
> On Thu, Jan 12, 2023 at 4:29 PM Kyotaro Horiguchi
> wrote:
>> IMHO, it's a bit scaring to me to push down the execution stack by
>> that large size. I tend to choose the (current) possible memory
>> wasting only on startup process t
On Thu, Jan 12, 2023 at 1:59 PM Kyotaro Horiguchi
wrote:
>
> At Mon, 9 Jan 2023 20:00:00 +0530, Bharath Rupireddy
> wrote in
> > I propose to statically allocate these two pages using PGAlignedBlock
> > structure lazily in verifyBackupPageConsistency() to not waste dynamic
> > memory worth 2*BLC
On Thu, Jan 12, 2023 at 4:29 PM Kyotaro Horiguchi
wrote:
>
> At Mon, 9 Jan 2023 20:00:00 +0530, Bharath Rupireddy
> wrote in
> > I propose to statically allocate these two pages using PGAlignedBlock
> > structure lazily in verifyBackupPageConsistency() to not waste dynamic
> > memory worth 2*BLC
At Mon, 9 Jan 2023 20:00:00 +0530, Bharath Rupireddy
wrote in
> I propose to statically allocate these two pages using PGAlignedBlock
> structure lazily in verifyBackupPageConsistency() to not waste dynamic
> memory worth 2*BLCKSZ bytes. I'm attaching a small patch herewith.
>
> Thoughts?
IMHO
Hi,
Postgres verifies consistency of FPI from WAL record with the replayed
page during recovery in verifyBackupPageConsistency() when either
wal_consistency_checking for the resource manager is enabled or a WAL
record with XLR_CHECK_CONSISTENCY flag is inserted. While doing so, it
uses two interme
