On Sun, Aug 25, 2019 at 9:46 AM Andres Freund wrote:
> > Maybe we should just use std::unique_ptr's constructor, ie give it new
> > ImportMayTy() instead of using make_unique(), even though that's not
> > cool C++ these days?
>
> Yea, wfm. do you want to make it so?
Done.
--
Thomas Munro
https:
Andres Freund writes:
> On August 24, 2019 2:37:55 PM PDT, Tom Lane wrote:
>> I know it's the development branch. The question is whether this
>> breakage is something *they* ought to be fixing. If not, I'm
>> worried that we're too much in bed with implementation details
>> of LLVM that we sho
Hi,
On 2019-08-25 09:15:35 +1200, Thomas Munro wrote:
> On Sun, Aug 25, 2019 at 8:24 AM Andres Freund wrote:
> > On August 24, 2019 1:08:11 PM PDT, Thomas Munro
> > wrote:
> > >Perhaps we'll need some macrology to select between llvm and std
> > >versions? I am guessing we can't decree that Po
Hi,
On August 24, 2019 2:37:55 PM PDT, Tom Lane wrote:
>Andres Freund writes:
>> On August 24, 2019 1:57:56 PM PDT, Tom Lane
>wrote:
>>> So we're depending on APIs that upstream doesn't think are stable?
>
>> Seawasp iirc builds against the development branch of llvm, which
>explains why we se
Andres Freund writes:
> On August 24, 2019 1:57:56 PM PDT, Tom Lane wrote:
>> So we're depending on APIs that upstream doesn't think are stable?
> Seawasp iirc builds against the development branch of llvm, which explains
> why we see failures there. Does that address what you are concerned ab
On Sun, Aug 25, 2019 at 8:24 AM Andres Freund wrote:
> On August 24, 2019 1:08:11 PM PDT, Thomas Munro
> wrote:
> >Perhaps we'll need some macrology to select between llvm and std
> >versions? I am guessing we can't decree that PostgreSQL's minimum C++
> >level is C++14 and simply change it to
Hi,
On August 24, 2019 1:57:56 PM PDT, Tom Lane wrote:
>Andres Freund writes:
>> On August 24, 2019 1:08:11 PM PDT, Thomas Munro
> wrote:
>>> That's because they just moved to C++14 and replaced their own
>>> llvm::make_unique<> with std::make_unique<>:
>>>
>https://github.com/llvm-mirror/llvm/c
Andres Freund writes:
> On August 24, 2019 1:08:11 PM PDT, Thomas Munro
> wrote:
>> That's because they just moved to C++14 and replaced their own
>> llvm::make_unique<> with std::make_unique<>:
>> https://github.com/llvm-mirror/llvm/commit/114087caa6f95b526861c3af94b3093d9444c57b
>> Perhaps we'
Hi,
On August 24, 2019 1:08:11 PM PDT, Thomas Munro wrote:
>Hi,
>
>llvmjit_inline.cpp:177:55: error: ‘make_unique’ is not a member of
>‘llvm’
> std::unique_ptr globalsToInline =
>llvm::make_unique();
>
>That's because they just moved to C++14 and replaced their own
>llvm::make_unique<> with std:
Hi,
llvmjit_inline.cpp:177:55: error: ‘make_unique’ is not a member of ‘llvm’
std::unique_ptr globalsToInline =
llvm::make_unique();
That's because they just moved to C++14 and replaced their own
llvm::make_unique<> with std::make_unique<>:
https://github.com/llvm-mirror/llvm/commit/114087caa6
10 matches
Mail list logo
