Re: LDAP check flapping on crake due to race

2020-08-02 Thread Thomas Munro
On Mon, Aug 3, 2020 at 12:29 PM Noah Misch wrote: > On Mon, Aug 03, 2020 at 12:12:57PM +1200, Thomas Munro wrote: > > On Mon, Aug 3, 2020 at 4:09 AM Tom Lane wrote: > > > I'm inclined to suggest that the LDAP test's test_access could use > > > an empty stdin and pass "-c 'SELECT 1'" as a command

Re: LDAP check flapping on crake due to race

2020-08-02 Thread Noah Misch
On Mon, Aug 03, 2020 at 12:12:57PM +1200, Thomas Munro wrote: > On Mon, Aug 3, 2020 at 4:09 AM Tom Lane wrote: > > I'm inclined to suggest that the LDAP test's test_access could use > > an empty stdin and pass "-c 'SELECT 1'" as a command line option > > instead. (Maybe that's exactly what you me

Re: LDAP check flapping on crake due to race

2020-08-02 Thread Thomas Munro
On Mon, Aug 3, 2020 at 4:09 AM Tom Lane wrote: > I'm inclined to suggest that the LDAP test's test_access could use > an empty stdin and pass "-c 'SELECT 1'" as a command line option > instead. (Maybe that's exactly what you meant, but I'm not sure.) Good idea. Here's a patch like that. > I've

Re: LDAP check flapping on crake due to race

2020-08-02 Thread Tom Lane
Noah Misch writes: > On Sun, Aug 02, 2020 at 05:29:57PM +1200, Thomas Munro wrote: >> There are one or two failures per month on crake. It looks like when >> authentication is rejected, as expected in the tests, the psql process >> is exiting, but there is a race where the Perl script still wants

Re: LDAP check flapping on crake due to race

2020-08-01 Thread Noah Misch
On Sun, Aug 02, 2020 at 05:29:57PM +1200, Thomas Munro wrote: > There are one or two failures per month on crake. It looks like when > authentication is rejected, as expected in the tests, the psql process > is exiting, but there is a race where the Perl script still wants to > write a dummy query

LDAP check flapping on crake due to race

2020-08-01 Thread Thomas Munro
Hi, There are one or two failures per month on crake. It looks like when authentication is rejected, as expected in the tests, the psql process is exiting, but there is a race where the Perl script still wants to write a dummy query to its stdin (?), so you get: psql: FATAL: LDAP authentication