Re: Jumble the CALL command in pg_stat_statements

2023-09-27 Thread Michael Paquier
On Wed, Sep 13, 2023 at 11:09:19PM +, Imseih (AWS), Sami wrote: > I do have a patch for this with test cases, > 0001-v1-Jumble-the-SET-command.patch > If you feel this needs a separate discussion I can start one. Agreed tha tthis should have its own thread with a proper subject. > In the pat

Re: Jumble the CALL command in pg_stat_statements

2023-09-13 Thread Imseih (AWS), Sami
> Still this grouping is much better than having thousands of entries > with different values. I am not sure if we should bother improving > that more than what you suggest that, especially as FuncExpr->args can > itself include Const nodes as far as I recall. I agree. > As far as the SET command

Re: Jumble the CALL command in pg_stat_statements

2023-09-12 Thread Michael Paquier
On Wed, Sep 13, 2023 at 12:48:48AM +, Imseih (AWS), Sami wrote: > The patch also modifies existing test cases for CALL handling in > pg_stat_statements > and adds additional tests which prove that a CALL to an overloaded procedure > will generate a different query_id. +CALL overload(1); +CALL

Jumble the CALL command in pg_stat_statements

2023-09-12 Thread Imseih (AWS), Sami
Hi, The proposal by Bertrand in CC to jumble CALL and SET in [1] was rejected at the time for a more robust solution to jumble DDL. Michael also in CC made this possible with commit 3db72ebcbe. The attached patch takes advantage of the jumbling infrastructure added in the above mentioned commit