Re: Issues with hash and GiST LP_DEAD setting for kill_prior_tuple

2025-07-15 Thread Peter Geoghegan
On Tue, Jul 15, 2025 at 2:19 PM Peter Geoghegan wrote: > * gistkillitems() correctly checks if the page's LSN has changed in > the period between when we initially read the leaf page and the period > when/after we accessed the heap. But (unlike nbtree), it fails to > account for unlogged relations

Issues with hash and GiST LP_DEAD setting for kill_prior_tuple

2025-07-15 Thread Peter Geoghegan
Both hash and GiST indexes set LP_DEAD bits for kill_prior_tuple, using an approach based on that of nbtree. hash gained this ability in commit 6977b8b7f4, while GiST gained it in commit 013ebc0a7b. gistkillitems() and _hash_kill_items() both have similar bugs: * gistkillitems() correctly checks