Re: Issue in ExecCleanupTupleRouting()

2019-04-15 Thread Etsuro Fujita
(2019/04/15 13:32), David Rowley wrote: On Fri, 12 Apr 2019 at 01:06, Etsuro Fujita wrote: While working on an update-tuple-routing bug in postgres_fdw [1], I noticed this change to ExecCleanupTupleRouting() made by commit 3f2393edefa5ef2b6970a5a2fa2c7e9c55cc10cf: Added to open items list.

Re: Issue in ExecCleanupTupleRouting()

2019-04-15 Thread Etsuro Fujita
(2019/04/12 10:48), Amit Langote wrote: On 2019/04/11 22:28, David Rowley wrote: On Fri, 12 Apr 2019 at 01:06, Etsuro Fujita wrote: + /* +* Check if this result rel is one belonging to the node's subplans, +* if so, let ExecEndPlan() clean it up. +*/ + if (h

Re: Issue in ExecCleanupTupleRouting()

2019-04-14 Thread David Rowley
On Fri, 12 Apr 2019 at 01:06, Etsuro Fujita wrote: > While working on an update-tuple-routing bug in postgres_fdw [1], I > noticed this change to ExecCleanupTupleRouting() made by commit > 3f2393edefa5ef2b6970a5a2fa2c7e9c55cc10cf: Added to open items list. -- David Rowley htt

Re: Issue in ExecCleanupTupleRouting()

2019-04-11 Thread Amit Langote
On 2019/04/11 22:28, David Rowley wrote: > On Fri, 12 Apr 2019 at 01:06, Etsuro Fujita > wrote: >> + /* >> +* Check if this result rel is one belonging to the node's subplans, >> +* if so, let ExecEndPlan() clean it up. >> +*/ >> + if (htab) >> + { >> +

Re: Issue in ExecCleanupTupleRouting()

2019-04-11 Thread David Rowley
On Fri, 12 Apr 2019 at 01:06, Etsuro Fujita wrote: > + /* > +* Check if this result rel is one belonging to the node's subplans, > +* if so, let ExecEndPlan() clean it up. > +*/ > + if (htab) > + { > + Oid partoid; > + bool

Issue in ExecCleanupTupleRouting()

2019-04-11 Thread Etsuro Fujita
Hi, (added Alvaro, Amit, and David) While working on an update-tuple-routing bug in postgres_fdw [1], I noticed this change to ExecCleanupTupleRouting() made by commit 3f2393edefa5ef2b6970a5a2fa2c7e9c55cc10cf: + /* +* Check if this result rel is one belonging to the node's subplans