Paul Jungwirth writes:
> I tried a few refactoring approaches but the nicest seemed to be to keep the
> shared parts in
> inline_set_returning_function, but have it call out to either
> inline_sql_set_returning_function or
> inline_set_returning_function_with_support. The first patch just refa
On 9/3/24 09:42, Tom Lane wrote:
Paul Jungwirth writes:
Here are new patches using a new SupportRequestInlineSRF request type. They
include patches and
documentation.
I took a look through this. I feel like we're still some way away
from having something committable. I've got two main comp
Paul Jungwirth writes:
> Here are new patches using a new SupportRequestInlineSRF request type. They
> include patches and
> documentation.
I took a look through this. I feel like we're still some way away
from having something committable. I've got two main complaint
areas:
1. It doesn't se
On 7/26/24 11:58, Tom Lane wrote:
> Heikki Linnakangas writes:
>> On 28/06/2024 01:01, Paul Jungwirth wrote:
>>> Another approach I considered is using a separate support request, e.g.
SupportRequestInlineSRF, and
>>> just calling it from inline_set_returning_function. I didn't like having
two
Heikki Linnakangas writes:
> On 28/06/2024 01:01, Paul Jungwirth wrote:
>> Another approach I considered is using a separate support request, e.g.
>> SupportRequestInlineSRF, and
>> just calling it from inline_set_returning_function. I didn't like having two
>> support requests that
>> did almos
On 28/06/2024 01:01, Paul Jungwirth wrote:
If it seems good to let people use SupportRequestSimplify to make their SRFs be
inlineable, I'm
happy to add tests and docs. We should really document the idea of inlined
functions in general, so
I'll do that too.
Another approach I considered is usin
n't find any mention in our
docs though, so we should add that.)
[2] https://www.postgresql.org/docs/current/xfunc-optimization.html
[3] https://github.com/pjungwir/temporal_ops/blob/master/temporal_ops--1.0.0.sql
[4] https://github.com/pjungwir/temporal_ops/blob/inlined/temporal_ops.c
[5] https://git
