Re: Initdb failure

2019-07-30 Thread Michael Paquier
On Tue, Jul 30, 2019 at 03:30:12PM -0400, Tom Lane wrote: > On the whole though, I don't have a problem with the "do nothing" > answer. There's no security risk here, and no issue that seems > likely to arise in actual use cases rather than try-to-break-it > test scripts. +1. -- Michael signatu

Re: Initdb failure

2019-07-30 Thread Tom Lane
Robert Haas writes: > Agreed, but I think we should just do nothing. To actually fix this > in general, we'd have to get rid of every instance of MAXPGPATH in the > source tree: > [rhaas pgsql]$ git grep MAXPGPATH | wc -l > 611 I don't think it'd really be necessary to go that far. One of

Re: Initdb failure

2019-07-30 Thread Robert Haas
On Sat, Jul 27, 2019 at 2:22 AM Peter Eisentraut wrote: > I think if you want to make this more robust, get rid of the fixed-size > array, use dynamic allocation with PQExpBuffer, and let the operating > system complain if it doesn't like the directory name length. Agreed, but I think we should j

Re: Initdb failure

2019-07-26 Thread Peter Eisentraut
On 2019-07-25 17:09, Rafia Sabih wrote: > But on the other hand emitting the right error message atleast would > be good for the sake of correctness if nothing else. But yes that > definitely should be weighed against what is the effort required for > this. I think if you want to make this more ro

Re: Initdb failure

2019-07-25 Thread vignesh C
On Thu, Jul 25, 2019 at 8:39 PM Rafia Sabih wrote: > > On Thu, 25 Jul 2019 at 16:44, Tom Lane wrote: > > > > Rafia Sabih writes: > > > On Thu, 25 Jul 2019 at 13:50, vignesh C wrote: > > >>> Initdb fails when following path is provided as input: > > >>> datasadfasfdsafddsdatasadfasfdsafddsdatasa

Re: Initdb failure

2019-07-25 Thread Rafia Sabih
On Thu, 25 Jul 2019 at 16:44, Tom Lane wrote: > > Rafia Sabih writes: > > On Thu, 25 Jul 2019 at 13:50, vignesh C wrote: > >>> Initdb fails when following path is provided as input: > >>> datasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafdds

Re: Initdb failure

2019-07-25 Thread Tom Lane
Rafia Sabih writes: > On Thu, 25 Jul 2019 at 13:50, vignesh C wrote: >>> Initdb fails when following path is provided as input: >>> datasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdat

Re: Initdb failure

2019-07-25 Thread Rafia Sabih
On Thu, 25 Jul 2019 at 13:50, vignesh C wrote: > > On Thu, Jul 25, 2019 at 4:52 PM Rafia Sabih wrote: > > > > On Thu, 25 Jul 2019 at 07:39, vignesh C wrote: > > > > > > Hi, > > > > > > Initdb fails when following path is provided as input: > > > datasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsa

Re: Initdb failure

2019-07-25 Thread vignesh C
On Thu, Jul 25, 2019 at 4:52 PM Rafia Sabih wrote: > > On Thu, 25 Jul 2019 at 07:39, vignesh C wrote: > > > > Hi, > > > > Initdb fails when following path is provided as input: > > datasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadf

Re: Initdb failure

2019-07-25 Thread Rafia Sabih
On Thu, 25 Jul 2019 at 07:39, vignesh C wrote: > > Hi, > > Initdb fails when following path is provided as input: > datasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsda

Initdb failure

2019-07-24 Thread vignesh C
Hi, Initdb fails when following path is provided as input: datasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafddsdatasadfasfdsafdds/datasadfasfdsafddsdata