Re: Incremental sorts and EXEC_FLAG_REWIND

2020-05-09 Thread Tomas Vondra
On Fri, May 08, 2020 at 07:36:38PM -0400, James Coleman wrote: On Fri, May 8, 2020 at 7:14 PM Tomas Vondra wrote: On Fri, Apr 24, 2020 at 04:35:02PM -0400, James Coleman wrote: >On Sun, Apr 19, 2020 at 12:14 PM James Coleman wrote: >> >> On Wed, Apr 15, 2020 at 2:04 PM James Coleman wrote: >

Re: Incremental sorts and EXEC_FLAG_REWIND

2020-05-08 Thread James Coleman
On Fri, May 8, 2020 at 7:14 PM Tomas Vondra wrote: > > On Fri, Apr 24, 2020 at 04:35:02PM -0400, James Coleman wrote: > >On Sun, Apr 19, 2020 at 12:14 PM James Coleman wrote: > >> > >> On Wed, Apr 15, 2020 at 2:04 PM James Coleman wrote: > >> > > >> > On Wed, Apr 15, 2020 at 11:02 AM James Colem

Re: Incremental sorts and EXEC_FLAG_REWIND

2020-05-08 Thread Tomas Vondra
On Fri, Apr 24, 2020 at 04:35:02PM -0400, James Coleman wrote: On Sun, Apr 19, 2020 at 12:14 PM James Coleman wrote: On Wed, Apr 15, 2020 at 2:04 PM James Coleman wrote: > > On Wed, Apr 15, 2020 at 11:02 AM James Coleman wrote: > > > > On Tue, Apr 14, 2020 at 2:53 AM Michael Paquier wrote:

Re: Incremental sorts and EXEC_FLAG_REWIND

2020-05-07 Thread Jonathan S. Katz
On 5/7/20 5:07 PM, Tomas Vondra wrote: > On Thu, May 07, 2020 at 03:58:47PM -0400, James Coleman wrote: >> On Thu, May 7, 2020 at 2:57 PM Jonathan S. Katz >> wrote: >>> >>> ... >>> >>> With Beta 1 just around the corner[1], I wanted to check in to see if >>> this was closer to being committed so w

Re: Incremental sorts and EXEC_FLAG_REWIND

2020-05-07 Thread Tomas Vondra
On Thu, May 07, 2020 at 03:58:47PM -0400, James Coleman wrote: On Thu, May 7, 2020 at 2:57 PM Jonathan S. Katz wrote: ... With Beta 1 just around the corner[1], I wanted to check in to see if this was closer to being committed so we could close off the open item[2] prior the beta release. Th

Re: Incremental sorts and EXEC_FLAG_REWIND

2020-05-07 Thread James Coleman
On Thu, May 7, 2020 at 2:57 PM Jonathan S. Katz wrote: > > On 4/24/20 6:57 PM, Tomas Vondra wrote: > > On Fri, Apr 24, 2020 at 04:35:02PM -0400, James Coleman wrote: > >> On Sun, Apr 19, 2020 at 12:14 PM James Coleman wrote: > >>> > >>> On Wed, Apr 15, 2020 at 2:04 PM James Coleman wrote: > >>>

Re: Incremental sorts and EXEC_FLAG_REWIND

2020-05-07 Thread Jonathan S. Katz
On 4/24/20 6:57 PM, Tomas Vondra wrote: > On Fri, Apr 24, 2020 at 04:35:02PM -0400, James Coleman wrote: >> On Sun, Apr 19, 2020 at 12:14 PM James Coleman wrote: >>> >>> On Wed, Apr 15, 2020 at 2:04 PM James Coleman wrote: >>> > >>> > On Wed, Apr 15, 2020 at 11:02 AM James Coleman >>> wrote: >>>

Re: Incremental sorts and EXEC_FLAG_REWIND

2020-04-24 Thread Tomas Vondra
On Fri, Apr 24, 2020 at 04:35:02PM -0400, James Coleman wrote: On Sun, Apr 19, 2020 at 12:14 PM James Coleman wrote: On Wed, Apr 15, 2020 at 2:04 PM James Coleman wrote: > > On Wed, Apr 15, 2020 at 11:02 AM James Coleman wrote: > > > > On Tue, Apr 14, 2020 at 2:53 AM Michael Paquier wrote:

Re: Incremental sorts and EXEC_FLAG_REWIND

2020-04-24 Thread James Coleman
On Sun, Apr 19, 2020 at 12:14 PM James Coleman wrote: > > On Wed, Apr 15, 2020 at 2:04 PM James Coleman wrote: > > > > On Wed, Apr 15, 2020 at 11:02 AM James Coleman wrote: > > > > > > On Tue, Apr 14, 2020 at 2:53 AM Michael Paquier > > > wrote: > > > > > > > > Hi, > > > > > > > > When initial

Re: Incremental sorts and EXEC_FLAG_REWIND

2020-04-19 Thread James Coleman
On Wed, Apr 15, 2020 at 2:04 PM James Coleman wrote: > > On Wed, Apr 15, 2020 at 11:02 AM James Coleman wrote: > > > > On Tue, Apr 14, 2020 at 2:53 AM Michael Paquier wrote: > > > > > > Hi, > > > > > > When initializing an incremental sort node, we have the following as > > > of ExecInitIncremen

Re: Incremental sorts and EXEC_FLAG_REWIND

2020-04-15 Thread James Coleman
On Wed, Apr 15, 2020 at 11:02 AM James Coleman wrote: > > On Tue, Apr 14, 2020 at 2:53 AM Michael Paquier wrote: > > > > Hi, > > > > When initializing an incremental sort node, we have the following as > > of ExecInitIncrementalSort(): > > /* > > * Incremental sort can't be used with eit

Re: Incremental sorts and EXEC_FLAG_REWIND

2020-04-15 Thread James Coleman
On Tue, Apr 14, 2020 at 2:53 AM Michael Paquier wrote: > > Hi, > > When initializing an incremental sort node, we have the following as > of ExecInitIncrementalSort(): > /* > * Incremental sort can't be used with either EXEC_FLAG_REWIND, > * EXEC_FLAG_BACKWARD or EXEC_FLAG_MARK, beca

Incremental sorts and EXEC_FLAG_REWIND

2020-04-13 Thread Michael Paquier
Hi, When initializing an incremental sort node, we have the following as of ExecInitIncrementalSort(): /* * Incremental sort can't be used with either EXEC_FLAG_REWIND, * EXEC_FLAG_BACKWARD or EXEC_FLAG_MARK, because we only one of many sort * batches in the current sort state.