On Thu, Mar 29, 2018 at 03:29:24PM -0400, Bruce Momjian wrote:
> I am planning to look into this, and will convert to "an" in my proposed
> patch.
Thanks. Let's see that on another thread..
--
Michael
signature.asc
Description: PGP signature
On Thu, Mar 29, 2018 at 03:28:32PM -0400, Bruce Momjian wrote:
> Attached patch applied. It includes a suggested fix by Abhijit
> Menon-Sen.
Thanks Bruce.
--
Michael
signature.asc
Description: PGP signature
On Mon, Mar 5, 2018 at 07:42:40PM +1300, Thomas Munro wrote:
> On Mon, Mar 5, 2018 at 6:51 PM, Abhijit Menon-Sen
> wrote:
> > At 2018-03-05 14:42:14 +0900, mich...@paquier.xyz wrote:
> >> > - sinval is a signal invalidation, so it seems to me that "a" is
> >> > correct, not "an".
> >
> > I guess
On Mon, Mar 5, 2018 at 01:58:54PM +0900, Michael Paquier wrote:
> Hi all,
>
> While looking at something else, I have one one occurence of $subject.
> Looking more deeply at the code I have found 10 more of them, like:
> - sinval is a signal invalidation, so it seems to me that "a" is
> correct,
On Mon, Mar 5, 2018 at 07:23:22PM +1300, David Rowley wrote:
> On 5 March 2018 at 18:42, Michael Paquier wrote:
> > On Mon, Mar 05, 2018 at 01:58:54PM +0900, Michael Paquier wrote:
> >> Attached is a proposal of patch to fix all those things.
> >
> > And of course I forgot to attach the actual pa
Michael Paquier wrote:
> On Mon, Mar 05, 2018 at 07:42:40PM +1300, Thomas Munro wrote:
> > $ git grep ' a SQL ' | wc -l
> > 642
> > $ git grep ' an SQL ' | wc -l
> > 219
> >
> > /me grabs popcorn
>
> ess-queue-el, sir.
Yeah, but
http://patorjk.com/blog/2012/01/26/pronouncing-sql-s-q-l-
On Mon, Mar 05, 2018 at 07:42:40PM +1300, Thomas Munro wrote:
> $ git grep ' a SQL ' | wc -l
> 642
> $ git grep ' an SQL ' | wc -l
> 219
>
> /me grabs popcorn
ess-queue-el, sir.
--
Michael
signature.asc
Description: PGP signature
On Mon, Mar 5, 2018 at 6:51 PM, Abhijit Menon-Sen wrote:
> At 2018-03-05 14:42:14 +0900, mich...@paquier.xyz wrote:
>> > - sinval is a signal invalidation, so it seems to me that "a" is
>> > correct, not "an".
>
> I guess it depends on whether you read it as "sin-val" or "ess-inval".
$ git grep '
On 2018-03-05 11:21:18 +0530, Abhijit Menon-Sen wrote:
> At 2018-03-05 14:42:14 +0900, mich...@paquier.xyz wrote:
> >
> > > - sinval is a signal invalidation, so it seems to me that "a" is
> > > correct, not "an".
>
> I guess it depends on whether you read it as "sin-val" or "ess-inval".
It stand
On 5 March 2018 at 18:42, Michael Paquier wrote:
> On Mon, Mar 05, 2018 at 01:58:54PM +0900, Michael Paquier wrote:
>> Attached is a proposal of patch to fix all those things.
>
> And of course I forgot to attach the actual patch. (Thanks Thomas for
> telling me off-list).
If you're doing a roun
On Mon, Mar 05, 2018 at 11:21:18AM +0530, Abhijit Menon-Sen wrote:
> At 2018-03-05 14:42:14 +0900, mich...@paquier.xyz wrote:
>>
>>> - sinval is a signal invalidation, so it seems to me that "a" is
>>> correct, not "an".
>
> I guess it depends on whether you read it as "sin-val" or "ess-inval".
T
At 2018-03-05 14:42:14 +0900, mich...@paquier.xyz wrote:
>
> > - sinval is a signal invalidation, so it seems to me that "a" is
> > correct, not "an".
I guess it depends on whether you read it as "sin-val" or "ess-inval".
> diff --git a/src/backend/access/gin/ginvacuum.c
> b/src/backend/access/g
On Mon, Mar 05, 2018 at 01:58:54PM +0900, Michael Paquier wrote:
> While looking at something else, I have one one occurence of $subject.
> Looking more deeply at the code I have found 10 more of them, like:
> - sinval is a signal invalidation, so it seems to me that "a" is
> correct, not "an".
> -
Hi all,
While looking at something else, I have one one occurence of $subject.
Looking more deeply at the code I have found 10 more of them, like:
- sinval is a signal invalidation, so it seems to me that "a" is
correct, not "an".
- I bumped into "an" being used instead of "and" in the GIN code.
-
14 matches
Mail list logo
