Re: Incorrect comment in tableam.h regarding GetHeapamTableAmRoutine()

2023-11-27 Thread Michael Paquier
On Mon, Nov 27, 2023 at 02:14:32PM +0800, Richard Guo wrote: > +1. Nice catch. Thanks, applied it. -- Michael signature.asc Description: PGP signature

Re: Incorrect comment in tableam.h regarding GetHeapamTableAmRoutine()

2023-11-26 Thread Richard Guo
On Mon, Nov 27, 2023 at 1:50 PM Michael Paquier wrote: > I have noticed that GetHeapamTableAmRoutine() is listed as being a > member of tableamapi.c but it is a convenience routine located in > heapam_handler.c. Shouldn't the header be fixed with something like > the attached? +1. Nice catch.

Incorrect comment in tableam.h regarding GetHeapamTableAmRoutine()

2023-11-26 Thread Michael Paquier
Hi all, I have noticed that GetHeapamTableAmRoutine() is listed as being a member of tableamapi.c but it is a convenience routine located in heapam_handler.c. Shouldn't the header be fixed with something like the attached? Thoughts or comments? -- Michael diff --git a/src/include/access/tableam.