Re: Incorrect assert in libpqwalreceiver

2025-03-09 Thread Heikki Linnakangas
On 09/03/2025 10:09, Jacob Brazeal wrote: The libpqrcv_connect function asserts 'Assert(i < sizeof(keys))', where keys is declared as const char *keys[6];. However, sizeof(keys) is not the correct way to check the array length (on my system, for example, it's 48 = 6 * 8 at this callsite, not 6

Incorrect assert in libpqwalreceiver

2025-03-09 Thread Jacob Brazeal
Hello hackers, The libpqrcv_connect function asserts 'Assert(i < sizeof(keys))', where keys is declared as const char *keys[6];. However, sizeof(keys) is not the correct way to check the array length (on my system, for example, it's 48 = 6 * 8 at this callsite, not 6.) I attached a patch to fix