Re: Incorrect GUC descriptions in docs and postgresql.conf.sample

2021-05-26 Thread Michael Paquier
On Wed, May 26, 2021 at 11:10:22AM +0900, Michael Paquier wrote: > There is one point where you are right here: log_lock_waits has no > need to be changed. Looks like I checked too many things at once. Fixed that, did one extra round of review, and applied. -- Michael signature.asc Description:

Re: Incorrect GUC descriptions in docs and postgresql.conf.sample

2021-05-25 Thread Michael Paquier
On Tue, May 25, 2021 at 09:01:30PM -0500, Justin Pryzby wrote: > On Tue, May 25, 2021 at 08:43:14PM -0500, Justin Pryzby wrote: >> Your patch adds documentation about GUCs that can only be set at server >> start/config/commandline. > > Oh: I realized that I read too quickly and misinterpretted wha

Re: Incorrect GUC descriptions in docs and postgresql.conf.sample

2021-05-25 Thread Justin Pryzby
On Tue, May 25, 2021 at 08:43:14PM -0500, Justin Pryzby wrote: > Your patch adds documentation about GUCs that can only be set at server > start/config/commandline. Oh: I realized that I read too quickly and misinterpretted what "only be set in the config" means (I know I'm not the only one). Oop

Re: Incorrect GUC descriptions in docs and postgresql.conf.sample

2021-05-25 Thread Justin Pryzby
Your patch adds documentation about GUCs that can only be set at server start/config/commandline. But it's not true for any of these, which are all HUP/SUSET. Please double check your logic :) src/backend/utils/misc/guc.c: {"autovacuum_work_mem", PGC_SIGHUP, RESOURCES_MEM, src/backend/

Incorrect GUC descriptions in docs and postgresql.conf.sample

2021-05-25 Thread Michael Paquier
Hi all, I got curious with what Justin just told here with max_logical_replication_workers: https://www.postgresql.org/message-id/20210526001359.ge3...@telsasoft.com And while looking at the full set of GUCs, I noticed much more than one parameter that needed adjustments in the documentation when