Re: Inconsistent error handling in the openssl init code

2019-02-08 Thread Daniel Gustafsson
> On 8 Feb 2019, at 12:01, Peter Eisentraut > wrote: > > On 08/02/2019 11:01, Michael Paquier wrote: >> On Fri, Feb 08, 2019 at 09:36:59AM +0100, Daniel Gustafsson wrote: >>> Done, thanks! I took the liberty to mark you as reviewer since you’ve >>> already >>> spent time looking at the patch.

Re: Inconsistent error handling in the openssl init code

2019-02-08 Thread Peter Eisentraut
On 08/02/2019 11:01, Michael Paquier wrote: > On Fri, Feb 08, 2019 at 09:36:59AM +0100, Daniel Gustafsson wrote: >> Done, thanks! I took the liberty to mark you as reviewer since you’ve >> already >> spent time looking at the patch. > > Thanks. Please note that I can take care of the patch in a

Re: Inconsistent error handling in the openssl init code

2019-02-08 Thread Michael Paquier
On Fri, Feb 08, 2019 at 09:36:59AM +0100, Daniel Gustafsson wrote: > Done, thanks! I took the liberty to mark you as reviewer since you’ve already > spent time looking at the patch. Thanks. Please note that I can take care of the patch in a couple of days if need be. -- Michael signature.asc D

Re: Inconsistent error handling in the openssl init code

2019-02-08 Thread Daniel Gustafsson
> On 8 Feb 2019, at 01:10, Michael Paquier wrote: > > On Thu, Feb 07, 2019 at 10:03:30AM +0100, Daniel Gustafsson wrote: >> Doh, managed to completely overlook that. The attached updated patch also >> fixes the comment, thanks! > > That looks fine to me. Could you just add it to the next CF as

Re: Inconsistent error handling in the openssl init code

2019-02-07 Thread Michael Paquier
On Thu, Feb 07, 2019 at 10:03:30AM +0100, Daniel Gustafsson wrote: > Doh, managed to completely overlook that. The attached updated patch also > fixes the comment, thanks! That looks fine to me. Could you just add it to the next CF as a bug fix so as we don't forget? I am pretty sure that Peter

Re: Inconsistent error handling in the openssl init code

2019-02-07 Thread Daniel Gustafsson
> On 7 Feb 2019, at 05:12, Michael Paquier wrote: > > On Wed, Feb 06, 2019 at 11:18:22PM +0100, Daniel Gustafsson wrote: >> The errorhandling in be_tls_init(), and functions called from it, set the >> appropriate elevel by the isServerStart. ssl_protocol_version_to_openssl() >> is >> however er

Re: Inconsistent error handling in the openssl init code

2019-02-06 Thread Michael Paquier
On Wed, Feb 06, 2019 at 11:18:22PM +0100, Daniel Gustafsson wrote: > The errorhandling in be_tls_init(), and functions called from it, set the > appropriate elevel by the isServerStart. ssl_protocol_version_to_openssl() is > however erroring out unconditionally with ERROR on invalid TLS versions.

Inconsistent error handling in the openssl init code

2019-02-06 Thread Daniel Gustafsson
The errorhandling in be_tls_init(), and functions called from it, set the appropriate elevel by the isServerStart. ssl_protocol_version_to_openssl() is however erroring out unconditionally with ERROR on invalid TLS versions. The attached patch adds isServerStart handling to the TLS version handli