Re: Inaccurate comments in ReorderBufferCheckMemoryLimit()

2023-08-01 Thread Masahiko Sawada
On Wed, Aug 2, 2023 at 11:21 AM Amit Kapila wrote: > > On Tue, Aug 1, 2023 at 2:06 PM Masahiko Sawada wrote: > > > > On Tue, Aug 1, 2023 at 11:33 AM Amit Kapila wrote: > > > > > > On Mon, Jul 31, 2023 at 8:46 PM Masahiko Sawada > > > wrote: > > > > > > > > While reading the code, I realized th

Re: Inaccurate comments in ReorderBufferCheckMemoryLimit()

2023-08-01 Thread Amit Kapila
On Tue, Aug 1, 2023 at 2:06 PM Masahiko Sawada wrote: > > On Tue, Aug 1, 2023 at 11:33 AM Amit Kapila wrote: > > > > On Mon, Jul 31, 2023 at 8:46 PM Masahiko Sawada > > wrote: > > > > > > While reading the code, I realized that the following code comments > > > might not be accurate: > > > > >

Re: Inaccurate comments in ReorderBufferCheckMemoryLimit()

2023-08-01 Thread Masahiko Sawada
On Tue, Aug 1, 2023 at 11:33 AM Amit Kapila wrote: > > On Mon, Jul 31, 2023 at 8:46 PM Masahiko Sawada wrote: > > > > While reading the code, I realized that the following code comments > > might not be accurate: > > > > /* > > * Pick the largest transaction (or subtransaction) a

Re: Inaccurate comments in ReorderBufferCheckMemoryLimit()

2023-07-31 Thread Amit Kapila
On Mon, Jul 31, 2023 at 8:46 PM Masahiko Sawada wrote: > > While reading the code, I realized that the following code comments > might not be accurate: > > /* > * Pick the largest transaction (or subtransaction) and evict it from > * memory by streaming, if possible. Oth

Inaccurate comments in ReorderBufferCheckMemoryLimit()

2023-07-31 Thread Masahiko Sawada
Hi all, While reading the code, I realized that the following code comments might not be accurate: /* * Pick the largest transaction (or subtransaction) and evict it from * memory by streaming, if possible. Otherwise, spill to disk. */ if (ReorderBuffer