Re: Improved tab completion for PostgreSQL parameters in enums

2021-10-13 Thread bt21masumurak
Thank you for comments. I do not think this is an improvement. It will result in omitting quotes in some cases where they're not optional. Try it with a value such as "all", for example. This would break the completion of enum entries that require quotes to work properly for some of their v

Re: Improved tab completion for PostgreSQL parameters in enums

2021-10-06 Thread Tom Lane
bt21masumurak writes: > If you do tab completion in a situation like A, you will see ["on"] > instead of [on]. > A : "ALTER SYSTEM SET wal_compression TO " > I made a patch for this problem. I do not think this is an improvement. It will result in omitting quotes in some cases where they're n

Re: Improved tab completion for PostgreSQL parameters in enums

2021-10-05 Thread Michael Paquier
On Wed, Oct 06, 2021 at 02:24:40PM +0900, bt21masumurak wrote: > If you do tab completion in a situation like A, you will see ["on"] instead > of [on]. > > A : "ALTER SYSTEM SET wal_compression TO " > > I made a patch for this problem. This would break the completion of enum entries that require

Improved tab completion for PostgreSQL parameters in enums

2021-10-05 Thread bt21masumurak
Hi If you do tab completion in a situation like A, you will see ["on"] instead of [on]. A : "ALTER SYSTEM SET wal_compression TO " I made a patch for this problem. regards, Kosei Masumuradiff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c index 4155d81252..86087e790b 10064