Re: Improve verification of recovery_target_timeline GUC.

2025-04-25 Thread David Steele
1475dc8c86ef29fe3c9305d2e0 Mon Sep 17 00:00:00 2001 From: David Steele Date: Fri, 25 Apr 2025 13:37:41 + Subject: Improve verification of recovery_target_timeline GUC. Currently check_recovery_target_timeline() converts any value that is not current, latest, or a valid integer to 0. So for exa

Re: Improve verification of recovery_target_timeline GUC.

2025-04-24 Thread Michael Paquier
On Thu, Apr 24, 2025 at 03:34:29PM +, David Steele wrote: > Done. This means there are no commas in the upper bound but I don't think > it's a big deal and it more closely matches other GUC messages. One thing that I have double-checked is if we have similar messages for GUCs that are defined

Re: Improve verification of recovery_target_timeline GUC.

2025-04-24 Thread David Steele
r as I know. Thanks, -DavidFrom 2ccf6f207a14dafe1a426208618ae7690c4513a2 Mon Sep 17 00:00:00 2001 From: David Steele Date: Thu, 24 Apr 2025 15:11:51 + Subject: Improve verification of recovery_target_timeline GUC. Currently check_recovery_target_timeline() converts any value that is not curr

Re: Improve verification of recovery_target_timeline GUC.

2025-02-13 Thread Michael Paquier
On Fri, Jan 24, 2025 at 01:36:45PM +, David Steele wrote: > I attached the wrong patch. Oops! Thanks for the new patch. > + timeline = strtoull(*newval, &endp, 0); > + > + if (*endp != '\0' || errno == EINVAL || errno == ERANGE) > { >

Re: Improve verification of recovery_target_timeline GUC.

2025-01-24 Thread David Steele
9efe Mon Sep 17 00:00:00 2001 From: David Steele Date: Thu, 23 Jan 2025 14:40:43 + Subject: Improve verification of recovery_target_timeline GUC. Currently check_recovery_target_timeline() converts any value that is not current, latest, or a valid integer to 0. So for example: recovery_target_

Re: Improve verification of recovery_target_timeline GUC.

2025-01-23 Thread Michael Paquier
On Thu, Jan 23, 2025 at 02:53:39PM +, David Steele wrote: > Currently check_recovery_target_timeline() converts any value that is not > current, latest, or a valid integer to 0. So for example: > > recovery_target_timeline = 'currrent' > > results in the following error: > > FATAL: 22023: r

Improve verification of recovery_target_timeline GUC.

2025-01-23 Thread David Steele
Hackers, Currently check_recovery_target_timeline() converts any value that is not current, latest, or a valid integer to 0. So for example: recovery_target_timeline = 'currrent' results in the following error: FATAL: 22023: recovery target timeline 0 does not exist Since there is no range