Re: Improve new hash partition bound check error messages

2021-02-21 Thread Peter Eisentraut
On 15.02.21 17:45, Peter Eisentraut wrote: On 2021-02-03 15:52, Peter Eisentraut wrote: On 2021-02-02 13:26, Heikki Linnakangas wrote: How about this? CREATE TABLE fail_part PARTITION OF hash_parted FOR VALUES WITH (MODULUS 25, REMAINDER 3); ERROR:  every hash partition modulus must be a facto

Re: Improve new hash partition bound check error messages

2021-02-15 Thread Peter Eisentraut
Mon, 15 Feb 2021 17:10:11 +0100 Subject: [PATCH v2] Improve new hash partition bound check error messages For the error message "every hash partition modulus must be a factor of the next larger modulus", add a detail message that shows the particular numbers involved. Also comment the code mo

Re: Improve new hash partition bound check error messages

2021-02-03 Thread Peter Eisentraut
On 2021-02-02 13:26, Heikki Linnakangas wrote: How about this? CREATE TABLE fail_part PARTITION OF hash_parted FOR VALUES WITH (MODULUS 25, REMAINDER 3); ERROR: every hash partition modulus must be a factor of the next larger modulus DETAIL: 25 is not divisible by 10, the modulus of existing p

Re: Improve new hash partition bound check error messages

2021-02-02 Thread Heikki Linnakangas
On 02/02/2021 12:35, Peter Eisentraut wrote: I had a bit of trouble parsing the error message "every hash partition modulus must be a factor of the next larger modulus", so I went into the code, added some comments and added errdetail messages for each case. I think it's a bit clearer now. Yea

Re: Improve new hash partition bound check error messages

2021-02-02 Thread Amit Langote
On Tue, Feb 2, 2021 at 7:36 PM Peter Eisentraut wrote: > I had a bit of trouble parsing the error message "every hash partition > modulus must be a factor of the next larger modulus", so I went into the > code, added some comments and added errdetail messages for each case. I > think it's a bit c

Improve new hash partition bound check error messages

2021-02-02 Thread Peter Eisentraut
3aed36729da22e1 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 2 Feb 2021 11:21:21 +0100 Subject: [PATCH] Improve new hash partition bound check error messages For the error message "every hash partition modulus must be a factor of the next larger modulus", add a detail message