ine_count' as an argument but
> 'PG_TEST_FILE_TRIM_LINES' environment variable overrides it. Should I
> document 'PG_TEST_FILE_TRIM_LINES' somewhere?
Documentation is required in regress.sgml, yes.
> 0002: 'Improve error reporting in 027_stream_regress test
nce, but it is easy to use.
>
> Sounds fine to me. Thanks!
I added that as 0001. I used a shifting method for the 'tail'
direction to not use too much memory. I found that there is
'File::ReadBackwards' in Perl but you need to install it, so I didn't
use it.
Now pat
On Wed, Jul 16, 2025 at 02:32:53PM +0300, Nazir Bilal Yavuz wrote:
> On Wed, 16 Jul 2025 at 04:39, Michael Paquier wrote:
>> Hmm. Is that actually useful as we know that the standby has been
>> stalen down when running the test? Even if we report something, we
>> could always trim the output, li
Hi,
Thanks for looking into this!
On Wed, 16 Jul 2025 at 04:39, Michael Paquier wrote:
>
> On Tue, Jul 01, 2025 at 10:57:11AM +0300, Nazir Bilal Yavuz wrote:
> > On Mon, 30 Jun 2025 at 18:01, Andres Freund wrote:
> >> One thing I don't yet like is that I think we should report if the primary
>
On Tue, Jul 01, 2025 at 10:57:11AM +0300, Nazir Bilal Yavuz wrote:
> On Mon, 30 Jun 2025 at 18:01, Andres Freund wrote:
>> One thing I don't yet like is that I think we should report if the primary is
>> alive *before* reporting the diff and skipping reporting it if the primary
>> crashed. It's no
Yavuz
Microsoft
From b1039c23dc78934882c69329b8865fd5902cdcda Mon Sep 17 00:00:00 2001
From: Nazir Bilal Yavuz
Date: Tue, 17 Jun 2025 16:08:20 +0300
Subject: [PATCH v2] Improve error reporting in 027_stream_regress test
Previously, the 027_stream_regress test only reported that the regressio
Hi,
On 2025-06-30 16:01:04 +0300, Nazir Bilal Yavuz wrote:
> This patch aims to improve 027_stream_regress test's regression test
> error reporting per Andres' suggestion [1].
Thanks for working on that!
One thing I don't yet like is that I think we should report if the primary is
alive *before
[1]
https://www.postgresql.org/message-id/k46gdpibwaevxgb3cefgkl4weykcggal6evlbg5pcei4aswtli%40wrs732j5co3p
--
Regards,
Nazir Bilal Yavuz
Microsoft
From 8c1c69b42607b09dddc74ec25540b6afb48e0bd8 Mon Sep 17 00:00:00 2001
From: Nazir Bilal Yavuz
Date: Tue, 17 Jun 2025 16:08:20 +0300
Subject: [PATCH v1] Improve error
