Re: Improve error messages for database object stats manipulation functions during recovery

2024-11-19 Thread Fujii Masao
On 2024/11/16 2:36, Fujii Masao wrote: Sounds good! I've updated the hint messages as suggested and attached the revised patch. Thanks for the review! Unless there are any objections, I'll proceed with committing it. Pushed. Thanks! Regards, -- Fujii Masao Advanced Computing Technology C

Re: Improve error messages for database object stats manipulation functions during recovery

2024-11-15 Thread Fujii Masao
On 2024/11/15 20:59, Maxim Orlov wrote: +1 for the patch. Recently, one of our customer have tried to upgrade the replica, and, obviously, failed. I don't remember the exact error message, but for him it was not so clear that server is in recovery. Explicitly declaring error is the way to

Re: Improve error messages for database object stats manipulation functions during recovery

2024-11-15 Thread Fujii Masao
On 2024/11/13 6:09, Heikki Linnakangas wrote: On 25/10/2024 20:07, Fujii Masao wrote: Hi, When database object stats manipulation functions like pg_set_relation_stats() are run, they currently produce the following error and hint messages, which are "internal" and make it hard for users to

Re: Improve error messages for database object stats manipulation functions during recovery

2024-11-15 Thread Maxim Orlov
+1 for the patch. Recently, one of our customer have tried to upgrade the replica, and, obviously, failed. I don't remember the exact error message, but for him it was not so clear that server is in recovery. Explicitly declaring error is the way to go in my view. So, I consider this patch useful

Re: Improve error messages for database object stats manipulation functions during recovery

2024-11-12 Thread Heikki Linnakangas
On 25/10/2024 20:07, Fujii Masao wrote: Hi, When database object stats manipulation functions like pg_set_relation_stats() are run, they currently produce the following error and hint messages, which are "internal" and make it hard for users to understand the issue:   ERROR:  cannot acq

Improve error messages for database object stats manipulation functions during recovery

2024-10-25 Thread Fujii Masao
Hi, When database object stats manipulation functions like pg_set_relation_stats() are run, they currently produce the following error and hint messages, which are "internal" and make it hard for users to understand the issue: ERROR: cannot acquire lock mode ShareUpdateExclusiveLock on