On Wed, Jan 22, 2025 at 9:08 AM Peter Eisentraut wrote:
> > It might be worth holding off for now. It's possible that I'll find
> > --header-insertion=iwyu has big problems in some unforeseen way. But
> > offhand it looks like a real improvement, even though I foresee
> > certain minor downsides.
On 15.01.25 20:51, Peter Geoghegan wrote:
On Wed, Jan 15, 2025 at 2:21 PM Peter Eisentraut wrote:
I have committed this. Thanks for the feedback.
Thanks for working on this.
Is it worth documenting how to get clangd working sensibly with
"--header-insertion=iwyu"?
I enabled it just now. I
On Wed, Jan 15, 2025 at 2:21 PM Peter Eisentraut wrote:
> I have committed this. Thanks for the feedback.
Thanks for working on this.
Is it worth documenting how to get clangd working sensibly with
"--header-insertion=iwyu"?
I enabled it just now. I find that I can now use completion with a
ty
On 10.01.25 09:10, Peter Eisentraut wrote:
On 02.01.25 17:15, Tom Lane wrote:
It's a fair point that some documentation could be provided. I suppose
we don't want to verbosely explain each pragma individually. Should
there be some central explanation, maybe in src/tools/pginclude/README?
Tha
On 02.01.25 17:15, Tom Lane wrote:
It's a fair point that some documentation could be provided. I suppose
we don't want to verbosely explain each pragma individually. Should
there be some central explanation, maybe in src/tools/pginclude/README?
That might do, but perhaps instead in the "Post
Peter Eisentraut writes:
> On 09.12.24 17:37, Tom Lane wrote:
>> In particular, this patchset introduces what seem like very
>> error-prone setups, such as in rmgrdesc.c where there's now one
>> group of #include's with "pragma: begin_keep/pragma: end_keep"
>> around it and another group without.
On 09.12.24 17:37, Tom Lane wrote:
Peter Eisentraut writes:
I have done a pass over much of the source code with
include-what-you-use (IWYU) to remove superfluous includes (commits
dbbca2cf299, 9be4e5d293b, ecb5af77987). Along the way I have collected
some pragma annotations to deal with excep
Peter Eisentraut writes:
> I have done a pass over much of the source code with
> include-what-you-use (IWYU) to remove superfluous includes (commits
> dbbca2cf299, 9be4e5d293b, ecb5af77987). Along the way I have collected
> some pragma annotations to deal with exceptions and special cases and
I have done a pass over much of the source code with
include-what-you-use (IWYU) to remove superfluous includes (commits
dbbca2cf299, 9be4e5d293b, ecb5af77987). Along the way I have collected
some pragma annotations to deal with exceptions and special cases and
peculiarities of the PostgreSQL
