On 2020-03-27 17:58, Vik Fearing wrote:
On 3/27/20 9:33 AM, Dean Rasheed wrote:
On Fri, 27 Mar 2020 at 11:29, Peter Eisentraut
wrote:
I have re-read everything and
expanded your patch a bit with additional documentation and comments in
the tests.
I looked that over, and it all looks good to
On 3/27/20 9:33 AM, Dean Rasheed wrote:
> On Fri, 27 Mar 2020 at 11:29, Peter Eisentraut
> wrote:
>>
>> I have re-read everything and
>> expanded your patch a bit with additional documentation and comments in
>> the tests.
>
> I looked that over, and it all looks good to me.
I concur. And it ma
On Fri, 27 Mar 2020 at 11:29, Peter Eisentraut
wrote:
>
> We appear to have lost track of this.
Ah yes, indeed!
> I have re-read everything and
> expanded your patch a bit with additional documentation and comments in
> the tests.
I looked that over, and it all looks good to me.
Regards,
Dean
We appear to have lost track of this. I have re-read everything and
expanded your patch a bit with additional documentation and comments in
the tests.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From cb1faa4
On Mon, 25 Feb 2019 at 12:47, Peter Eisentraut
wrote:
> > - and the column in new rows will automatically have values from the
> > - sequence assigned to it.
> > + and new rows in the column will automatically have values from the
> > + sequence assigned to them.
>
> The "it" r
On 2019-02-22 15:12, Dean Rasheed wrote:
> In particular, Syntax Rule 11b of section 14.11 says that an INSERT
> statement on a GENERATED ALWAYS identity column must specify an
> overriding clause, but it doesn't place any restriction on the type of
> overriding clause allowed. In other words it sh
So I started looking into the bug noted in [1], but before getting to
multi-row inserts, I concluded that the current single-row behaviour
isn't spec-compliant.
In particular, Syntax Rule 11b of section 14.11 says that an INSERT
statement on a GENERATED ALWAYS identity column must specify an
overr
