Re: IANA timezone abbreviations versus timezone_abbreviations

2025-01-10 Thread Tom Lane
I wrote: > Hmph ... the cfbot doesn't like that one bit. It appears that the > "LMT" abbrev is known in my machine's system-provided tzdata tree, > but not when building our own timezone files. I wonder if this is > exposing an existing bug (perhaps our copy of zic is too far out of > date?). Wi

Re: IANA timezone abbreviations versus timezone_abbreviations

2025-01-09 Thread Tom Lane
I wrote: > 0003 is new work that fixes the pg_timezone_abbrevs view so > that its output matches the new behavior. Hmph ... the cfbot doesn't like that one bit. It appears that the "LMT" abbrev is known in my machine's system-provided tzdata tree, but not when building our own timezone files. I

Re: IANA timezone abbreviations versus timezone_abbreviations

2025-01-09 Thread Tom Lane
Aleksander Alekseev writes: > I tested and reviewed the patch. It fixes the originally reported bug > and looks good to me. Thanks for looking at it! I'm not sure we have full consensus on this yet, but at least there seem to be a majority in favor. So here's a v2 with some loose ends cleaned up

Re: IANA timezone abbreviations versus timezone_abbreviations

2025-01-08 Thread Aleksander Alekseev
Hi Tom, > This mess was brought up in pgsql-bugs [1], but the solution > I propose here is invasive enough that I think it needs > discussion on -hackers. > > [...] I tested and reviewed the patch. It fixes the originally reported bug and looks good to me. > The only other way I can envision to

Re: IANA timezone abbreviations versus timezone_abbreviations

2024-12-30 Thread Tom Lane
"Jelte Fennema-Nio" writes: > The current situation seems utterly messed up though. One thing that > shocks me is that we're, by default and without warning, parsing IST as > Israel Standard Time instead of the timezone that 17% of the world's > population uses: Indian Standard Time. And even with

Re: IANA timezone abbreviations versus timezone_abbreviations

2024-12-30 Thread Jelte Fennema-Nio
On Sun Dec 29, 2024 at 11:56 PM CET, Tom Lane wrote: Hmm, I don't like your phrasing using "IANA time zone database", because that makes it sound like we'll take any abbreviation that's found anywhere in that whole data set. What the proposal actually does is to recognize any abbreviation that i

Re: IANA timezone abbreviations versus timezone_abbreviations

2024-12-30 Thread Jelte Fennema-Nio
On Sun Dec 29, 2024 at 11:49 PM CET, Jelte Fennema-Nio wrote: Maybe changing the default value of timezone_abbreviations is a better solution to the problem, or in addition to the proposed patch. To clarify, I meant maybe changing the default of timezone_abbreviations to be empty. It sounds lik

Re: IANA timezone abbreviations versus timezone_abbreviations

2024-12-29 Thread Tom Lane
"Jelte Fennema-Nio" writes: > I think it would be good to add some additional clarify here. It was > fairly confusing to me. Especially the last sentence, due to the use of > "active zone", even though it's really talking about the currently > active abbreviations list. Probably my confusion mostl

Re: IANA timezone abbreviations versus timezone_abbreviations

2024-12-29 Thread Jelte Fennema-Nio
On Mon Dec 16, 2024 at 8:57 PM CET, Tom Lane wrote: Andreas Karlsson writes: On 12/13/24 12:33 AM, Tom Lane wrote: I am not convinced this is an improvement. While this patch removes the round-trip hazard it also makes it confusing to use the timezone_abbreviations GUC since it can be overrid

Re: IANA timezone abbreviations versus timezone_abbreviations

2024-12-29 Thread Jelte Fennema-Nio
On Sun Dec 29, 2024 at 12:47 AM CET, Bruce Momjian wrote: On Mon, Dec 16, 2024 at 02:57:59PM -0500, Tom Lane wrote: Yes, your patch seems like a big improvement. +1 +Before consulting the timezone_abbreviations file, +PostgreSQL checks to see whether an +abbreviation used in date

Re: IANA timezone abbreviations versus timezone_abbreviations

2024-12-28 Thread Bruce Momjian
On Mon, Dec 16, 2024 at 02:57:59PM -0500, Tom Lane wrote: > Andreas Karlsson writes: > > On 12/13/24 12:33 AM, Tom Lane wrote: > >> What I think we should do about this is to teach timestamp > >> input to look into the current IANA time zone to see if it > >> knows the given abbreviation, and if s

Re: IANA timezone abbreviations versus timezone_abbreviations

2024-12-16 Thread Tom Lane
Andreas Karlsson writes: > On 12/13/24 12:33 AM, Tom Lane wrote: >> What I think we should do about this is to teach timestamp >> input to look into the current IANA time zone to see if it >> knows the given abbreviation, and if so use that meaning >> regardless of what timezone_abbreviations migh

Re: IANA timezone abbreviations versus timezone_abbreviations

2024-12-16 Thread Andreas Karlsson
On 12/13/24 12:33 AM, Tom Lane wrote: What I think we should do about this is to teach timestamp input to look into the current IANA time zone to see if it knows the given abbreviation, and if so use that meaning regardless of what timezone_abbreviations might say. This isn't particularly hard,

IANA timezone abbreviations versus timezone_abbreviations

2024-12-12 Thread Tom Lane
Although we've never documented this, it's been true for ages that timestamptz_out shows timezone abbreviations that are taken from the IANA tzdb data (in datestyles that use non-numeric timezone fields, which is all but ISO). Meanwhile, timestamptz_in recognizes timezone abbreviations if they mat