On Wed, Dec 5, 2018 at 05:22:25PM +0100, Daniel Gustafsson wrote:
> While looking at error messages downstream, I noticed a few hints and details
> in postgres which aren’t punctuated as per the style guide. The attached
> patch
> fixes the ones where it seemed reasonable to end with a period.
On Fri, Dec 07, 2018 at 01:27:52AM +0100, Daniel Gustafsson wrote:
> Oh.. sorry about that, I should’ve known better. Thanks for tidying up!
No problem. Thanks for the report and for caring on the matter. So do
I.
--
Michael
signature.asc
Description: PGP signature
> On 6 Dec 2018, at 23:51, Michael Paquier wrote:
>
> On Thu, Dec 06, 2018 at 09:44:22AM -0300, Alvaro Herrera wrote:
>> LGTM.
>
> Thanks Álvaro for the additional lookup. I have committed the patch,
> after updating the regression test output as this stuff was forgotten,
> but that was easy en
On Thu, Dec 06, 2018 at 09:44:22AM -0300, Alvaro Herrera wrote:
> LGTM.
Thanks Álvaro for the additional lookup. I have committed the patch,
after updating the regression test output as this stuff was forgotten,
but that was easy enough to fix.
--
Michael
signature.asc
Description: PGP signatur
On 2018-Dec-06, Daniel Gustafsson wrote:
> > On 6 Dec 2018, at 05:46, Michael Paquier wrote:
> >
> > On Wed, Dec 05, 2018 at 05:22:25PM +0100, Daniel Gustafsson wrote:
> >> While looking at error messages downstream, I noticed a few hints and
> >> details
> >> in postgres which aren’t punctuate
On Thu, Dec 06, 2018 at 09:42:26AM +0100, Daniel Gustafsson wrote:
> Ah, for some reason I hadn’t thought about looking at the GUCs. I agree with
> your findings, patch updated.
Thanks Daniel, that looks fine to me at quick glance. I'll try to get
that committed tomorrow my time if there are no
> On 6 Dec 2018, at 05:46, Michael Paquier wrote:
>
> On Wed, Dec 05, 2018 at 05:22:25PM +0100, Daniel Gustafsson wrote:
>> While looking at error messages downstream, I noticed a few hints and details
>> in postgres which aren’t punctuated as per the style guide. The attached
>> patch
>> fixes
On Wed, Dec 05, 2018 at 05:22:25PM +0100, Daniel Gustafsson wrote:
> While looking at error messages downstream, I noticed a few hints and details
> in postgres which aren’t punctuated as per the style guide. The attached
> patch
> fixes the ones where it seemed reasonable to end with a period.
While looking at error messages downstream, I noticed a few hints and details
in postgres which aren’t punctuated as per the style guide. The attached patch
fixes the ones where it seemed reasonable to end with a period.
cheers ./daniel
errhint_punctuation.patch
Description: Binary data
