Re: Header checking failures on LLVM-less machines

2019-01-28 Thread Tom Lane
Andres Freund writes: > I don't think we are actually contradicting each other. The aim of that > error was to prevent pieces of code that aren't conditional on > --with-llvm from including llvmjit.h. I was, for a moment and wrongly, > thinking that we could style the header in a way that'd make

Re: Header checking failures on LLVM-less machines

2019-01-28 Thread Andres Freund
Hi, On 2019-01-28 20:21:49 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2019-01-28 19:51:22 -0500, Tom Lane wrote: > >> I propose that we should fix this by making the whole bodies of those > >> two headers be #ifdef USE_LLVM. > > > Hm, I think it's sufficient that we error out if llvm

Re: Header checking failures on LLVM-less machines

2019-01-28 Thread Tom Lane
Andres Freund writes: > On 2019-01-28 19:51:22 -0500, Tom Lane wrote: >> I propose that we should fix this by making the whole bodies of those >> two headers be #ifdef USE_LLVM. > Hm, I think it's sufficient that we error out if llvm was configured, > we've sufficient buildfarm machines running w

Re: Header checking failures on LLVM-less machines

2019-01-28 Thread Andres Freund
On 2019-01-28 19:51:22 -0500, Tom Lane wrote: > On 2019-01-28 11:19:21 -0500, Tom Lane wrote: > > Since the LLVM stuff went in, src/tools/pginclude/cpluspluscheck > > fails on my main devel machine, because > > > > In file included from /tmp/cpluspluscheck.jobsM6/test.cpp:3: > > ./src/include/jit/

Re: Header checking failures on LLVM-less machines

2019-01-28 Thread Tom Lane
I wrote: > Since the LLVM stuff went in, src/tools/pginclude/cpluspluscheck > fails on my main devel machine, because Actually, it also fails on another machine that does have LLVM installed: In file included from /tmp/cpluspluscheck.LqnoZj/test.cpp:3: ./src/include/jit/llvmjit_emit.h: In functio

Header checking failures on LLVM-less machines

2019-01-28 Thread Tom Lane
Since the LLVM stuff went in, src/tools/pginclude/cpluspluscheck fails on my main devel machine, because In file included from /tmp/cpluspluscheck.jobsM6/test.cpp:3: ./src/include/jit/llvmjit_emit.h:13:25: error: llvm-c/Core.h: No such file or directory and then there's a bunch of ensuing spewag