Re: Header checker scripts should fail on failure

2022-08-15 Thread Andres Freund
Hi, On 2022-08-15 17:38:21 +1200, Thomas Munro wrote: > I thought commit 81b9f23c9c8 had my back, but nope, we still need to > make CI turn red if "headerscheck" and "cpluspluscheck" don't like our > patches (crake in the build farm should be a secondary defence...). > See attached. +1 Greetings

Re: Header checker scripts should fail on failure

2022-08-15 Thread Andrew Dunstan
On 2022-08-15 Mo 01:38, Thomas Munro wrote: > Hi, > > I thought commit 81b9f23c9c8 had my back, but nope, we still need to > make CI turn red if "headerscheck" and "cpluspluscheck" don't like our > patches (crake in the build farm should be a secondary defence...). > See attached. Yeah, the bui

Header checker scripts should fail on failure

2022-08-14 Thread Thomas Munro
Hi, I thought commit 81b9f23c9c8 had my back, but nope, we still need to make CI turn red if "headerscheck" and "cpluspluscheck" don't like our patches (crake in the build farm should be a secondary defence...). See attached. diff --git a/src/tools/pginclude/cpluspluscheck b/src/tools/pginclude/cp