Re: Header / Trailer Comment Typos for M4 macros

2020-04-22 Thread Tom Lane
Jesse Zhang writes: > I didn't make my question clear though: I'm curious what motivated the > original addition of -Wno-unused-command-line-argument in commit > 73b416b2e412, and how that problem did't quite manifest itself with Clang++. We didn't then have the convention of mentioning relevant

Re: Header / Trailer Comment Typos for M4 macros

2020-04-22 Thread Jesse Zhang
On Wed, Apr 22, 2020 at 12:29 PM Tom Lane wrote: > > Jesse Zhang writes: > > either way: either changing the macro names or changing the comment. PFA > > a patch that keeps the macro names. > > Pushed, thanks. > Thanks! > > Also in hindsight: it seems that, as suggested in the trailer typo, > >

Re: Header / Trailer Comment Typos for M4 macros

2020-04-22 Thread Tom Lane
Jesse Zhang writes: > While poking at the build system I stumbled upon some trivial trailer > comment inconsistencies in config/c-compiler.m4. They can be fixed > either way: either changing the macro names or changing the comment. PFA > a patch that keeps the macro names. Pushed, thanks. > In h

Header / Trailer Comment Typos for M4 macros

2020-04-22 Thread Jesse Zhang
Hi hackers, While poking at the build system I stumbled upon some trivial trailer comment inconsistencies in config/c-compiler.m4. They can be fixed either way: either changing the macro names or changing the comment. PFA a patch that keeps the macro names. In hindsight though, it seems that PGAC