Re: Have postgres.bki self-identify

2025-03-23 Thread Robert Haas
On Thu, Mar 20, 2025 at 3:47 PM David G. Johnston wrote: > While trying to find postgres.bki in my build directory searching for the > file name didn't work because there is no comment in the file containing the > file name; like there is in every other file we write or generate, including > th

Re: Have postgres.bki self-identify

2025-03-21 Thread Tom Lane
Robert Haas writes: > On Thu, Mar 20, 2025 at 3:47 PM David G. Johnston > wrote: >> While trying to find postgres.bki in my build directory searching for the >> file name didn't work because there is no comment in the file containing the >> file name; like there is in every other file we write

Re: Have postgres.bki self-identify

2025-03-20 Thread Robert Haas
On Thu, Mar 20, 2025 at 4:33 PM Tom Lane wrote: > While I don't care much about the filename per se, I do note that > we embed copyright notices into most generated files. Why > not this one? I don't care enough to argue about it. I suppose one can make an argument for a variety of things. --

Have postgres.bki self-identify

2025-03-20 Thread David G. Johnston
Hi! While trying to find postgres.bki in my build directory searching for the file name didn't work because there is no comment in the file containing the file name; like there is in every other file we write or generate, including the related *_d.h files. Add it. It probably belongs before the