On Wed, Nov 28, 2018 at 10:00:00AM +0900, Michael Paquier wrote:
> Okay, no problem with that.
Both things have been committed, but not back-patched.
--
Michael
signature.asc
Description: PGP signature
On Tue, Nov 27, 2018 at 05:59:34PM -0500, Andrew Dunstan wrote:
> I think you should just proceed with the changes above. I just had a quick
> look at the patch you posted before, and it looks sane enough.
Thanks for the feedback, Andrew. Let's wait a couple of days and see if
anybody has any obj
On 11/27/18 4:10 PM, Michael Paquier wrote:
On Tue, Nov 27, 2018 at 10:27:17AM +0900, Michael Paquier wrote:
Okay, let's do so by supporting correctly NO_INSTALLCHECK. My other
refactoring work can also live with that. Returning an empty list via
fetchTests() and bypass a run if nothing is p
On Tue, Nov 27, 2018 at 10:27:17AM +0900, Michael Paquier wrote:
> Okay, let's do so by supporting correctly NO_INSTALLCHECK. My other
> refactoring work can also live with that. Returning an empty list via
> fetchTests() and bypass a run if nothing is present looks fine to me.
> One extra thing
On Mon, Nov 26, 2018 at 12:41:21PM -0500, Andrew Dunstan wrote:
> It's not the buildfarm that is broken. Both contribcheck() and
> modulescheck() in vcregress.pl run in installcheck mode, i.e. with an
> already running database. That makes the tests run faster, because setting
> up and breaking dow
On 11/26/18 12:43 AM, Michael Paquier wrote:
Hi all,
As mentioned on this thread, I have been fighting a bit with the
buildfarm when trying to introduce new PGXS options for isolation and
TAP tests:
https://www.postgresql.org/message-id/e1gr4d0-0002yj...@gemulon.postgresql.org
However it happ
On Mon, Nov 26, 2018 at 02:43:02PM +0900, Michael Paquier wrote:
> Another option could also be to switch contribcheck and modulescheck
> so as they use a temporary installation, but that's a can of worms
> waiting to explode as MSVC makes more complicated the search for
> initdb and such (see the
Hi all,
As mentioned on this thread, I have been fighting a bit with the
buildfarm when trying to introduce new PGXS options for isolation and
TAP tests:
https://www.postgresql.org/message-id/e1gr4d0-0002yj...@gemulon.postgresql.org
However it happens that we have more issues than the buildfarm f
