Re: Handle TEMP_CONFIG for pg_regress style tests in pg_regress.c

2023-02-19 Thread Andres Freund
Hi, On 2023-02-19 11:13:38 -0500, Tom Lane wrote: > Andrew Dunstan writes: > > On 2023-02-19 Su 02:25, Peter Eisentraut wrote: > >> On 18.02.23 21:26, Andres Freund wrote: > >>> My inclination is to move TEMP_CONFIG support from the Makefile to > >>> pg_regress.c. That way it's consistent across

Re: Handle TEMP_CONFIG for pg_regress style tests in pg_regress.c

2023-02-19 Thread Tom Lane
Andrew Dunstan writes: > On 2023-02-19 Su 02:25, Peter Eisentraut wrote: >> On 18.02.23 21:26, Andres Freund wrote: >>> My inclination is to move TEMP_CONFIG support from the Makefile to >>> pg_regress.c. That way it's consistent across the build tools and isn't >>> duplicated. >> I'm having a ha

Re: Handle TEMP_CONFIG for pg_regress style tests in pg_regress.c

2023-02-19 Thread Andrew Dunstan
On 2023-02-19 Su 02:25, Peter Eisentraut wrote: On 18.02.23 21:26, Andres Freund wrote: When building with meson, TEMP_CONFIG is supported for TAP tests, but doesn't do anything for regress/isolation. The reason for that is that meson's (and ninja's) architecture is to separate "build setup"

Re: Handle TEMP_CONFIG for pg_regress style tests in pg_regress.c

2023-02-18 Thread Peter Eisentraut
On 18.02.23 21:26, Andres Freund wrote: When building with meson, TEMP_CONFIG is supported for TAP tests, but doesn't do anything for regress/isolation. The reason for that is that meson's (and ninja's) architecture is to separate "build setup" from the "build/test/whatever" stage, moving dynami

Handle TEMP_CONFIG for pg_regress style tests in pg_regress.c

2023-02-18 Thread Andres Freund
Hi, When building with meson, TEMP_CONFIG is supported for TAP tests, but doesn't do anything for regress/isolation. The reason for that is that meson's (and ninja's) architecture is to separate "build setup" from the "build/test/whatever" stage, moving dynamism (and more costly operations) to th