Re: Function for listing pg_wal/summaries directory

2024-10-11 Thread Nathan Bossart
On Fri, Oct 11, 2024 at 11:09:30AM +0900, Fujii Masao wrote: > On 2024/10/08 23:36, Nathan Bossart wrote: >> The patch posted upthread looks reasonable to me, so I'll go commit it soon >> unless there is any feedback. > > Thanks! The patch looks good to me, too. Committed. -- nathan

Re: Function for listing pg_wal/summaries directory

2024-10-10 Thread Fujii Masao
On 2024/10/08 23:36, Nathan Bossart wrote: On Tue, Oct 08, 2024 at 01:19:52PM +0900, Michael Paquier wrote: On Tue, Oct 08, 2024 at 12:41:16PM +0900, Fujii Masao wrote: One benefit of supporting something like pg_ls_summariesdir() is that it allows us to view the last modification time of ea

Re: Function for listing pg_wal/summaries directory

2024-10-08 Thread Nathan Bossart
On Tue, Oct 08, 2024 at 01:19:52PM +0900, Michael Paquier wrote: > On Tue, Oct 08, 2024 at 12:41:16PM +0900, Fujii Masao wrote: >> One benefit of supporting something like pg_ls_summariesdir() is that >> it allows us to view the last modification time of each WAL summary file >> and estimate when t

Re: Function for listing pg_wal/summaries directory

2024-10-07 Thread Michael Paquier
On Tue, Oct 08, 2024 at 12:41:16PM +0900, Fujii Masao wrote: > One benefit of supporting something like pg_ls_summariesdir() is that > it allows us to view the last modification time of each WAL summary file > and estimate when they'll be removed based on wal_summary_keep_time. > > Of course, we c

Re: Function for listing pg_wal/summaries directory

2024-10-07 Thread Fujii Masao
On 2024/10/07 23:35, Nathan Bossart wrote: On Mon, Oct 07, 2024 at 10:07:10AM +0900, Michael Paquier wrote: On Fri, Oct 04, 2024 at 10:02:11AM -0500, Nathan Bossart wrote: Could you explain why you feel the existing support functions are insufficient? Because it is not possible to outsourc

Re: Function for listing pg_wal/summaries directory

2024-10-07 Thread Nathan Bossart
On Mon, Oct 07, 2024 at 10:07:10AM +0900, Michael Paquier wrote: > On Fri, Oct 04, 2024 at 10:02:11AM -0500, Nathan Bossart wrote: >> Could you explain why you feel the existing support functions are >> insufficient? > > Because it is not possible to outsource the scan of pg_wal/summaries/ > to a

Re: Function for listing pg_wal/summaries directory

2024-10-06 Thread Michael Paquier
On Fri, Oct 04, 2024 at 10:02:11AM -0500, Nathan Bossart wrote: > Could you explain why you feel the existing support functions are > insufficient? Because it is not possible to outsource the scan of pg_wal/summaries/ to a different role, no? On HEAD, one would require a full access to the data f

Re: Function for listing pg_wal/summaries directory

2024-10-04 Thread Nathan Bossart
On Fri, Oct 04, 2024 at 11:32:08AM +0900, btogiwarayuushi wrote: > While WAL summaries feature and some support functions have been added in > version 17, merely listing the contents of the pg_wal/summaries directory is > missing. Could you explain why you feel the existing support functions are i

Function for listing pg_wal/summaries directory

2024-10-03 Thread btogiwarayuushi
Hi, While WAL summaries feature and some support functions have been added in version 17, merely listing the contents of the pg_wal/summaries directory is missing. As discussed in the pg_ls_archive_status() discussion, it would be convenient to add pg_ls_summariesdir() that lists the contents