Re: Frontends including fd.h

2018-12-01 Thread Sergei Kornilov
Hello I am +1 to have separate header with path names. Another examples are: - pg_ctl with many hardcoded files such as "promote" (PROMOTE_SIGNAL_FILE), "logrotate" (LOGROTATE_SIGNAL_FILE), postgresql.conf, PG_VERSION, backup_label, postmaster.pid - pg_basebackup with currently hardcoded "stand

Frontends including fd.h

2018-11-30 Thread Michael Paquier
Hi all, We have a couple of frontend binaries (pg_rewind, and now pg_verify_checksums) including directly fd.h to get the definitions of PG_TEMP_FILES_DIR and PG_TEMP_FILE_PREFIX. This is a poor choice I think, because fd.h is aimed at being used by the backend, and there are some routines decla