Re: Freeing sortgroupatts in use_physical_tlist

2022-07-15 Thread Zhihong Yu
On Fri, Jul 15, 2022 at 8:33 PM Tom Lane wrote: > Zhihong Yu writes: > > I was looking at the code in use_physical_tlist(). > > In the code block checking CP_LABEL_TLIST, I noticed that > > the Bitmapset sortgroupatts is not freed before returning from the > method. > > Looking at create_foreign

Re: Freeing sortgroupatts in use_physical_tlist

2022-07-15 Thread Tom Lane
Zhihong Yu writes: > I was looking at the code in use_physical_tlist(). > In the code block checking CP_LABEL_TLIST, I noticed that > the Bitmapset sortgroupatts is not freed before returning from the method. > Looking at create_foreignscan_plan() (in the same file): > bms_free(attrs_used)

Freeing sortgroupatts in use_physical_tlist

2022-07-15 Thread Zhihong Yu
Hi, I was looking at the code in use_physical_tlist(). In the code block checking CP_LABEL_TLIST, I noticed that the Bitmapset sortgroupatts is not freed before returning from the method. Looking at create_foreignscan_plan() (in the same file): bms_free(attrs_used); It seems the interme