Re: Forgot some LSN_FORMAT_ARGS() in xlogreader.c

2021-04-23 Thread Michael Paquier
On Fri, Apr 23, 2021 at 02:18:10PM +0900, Kyotaro Horiguchi wrote: > AFAICS it fixes the all remaining LSN parameters. Thanks for double-checking. I was not sure if I got all of them or not. Applied that now as of 4aba61b. -- Michael signature.asc Description: PGP signature

Re: Forgot some LSN_FORMAT_ARGS() in xlogreader.c

2021-04-22 Thread Kyotaro Horiguchi
At Fri, 23 Apr 2021 13:54:15 +0900, Michael Paquier wrote in > Hi all, > > As $subject says, I noticed that while scanning the area. Any > objections to make all that more consistent with the style of HEAD? > Please see the attached. AFAICS it fixes the all remaining LSN parameters. regards.

Re: Forgot some LSN_FORMAT_ARGS() in xlogreader.c

2021-04-22 Thread Tom Lane
Michael Paquier writes: > As $subject says, I noticed that while scanning the area. Any > objections to make all that more consistent with the style of HEAD? > Please see the attached. +1, it's not surprising some places didn't get that memo yet. regards, tom lane

Forgot some LSN_FORMAT_ARGS() in xlogreader.c

2021-04-22 Thread Michael Paquier
Hi all, As $subject says, I noticed that while scanning the area. Any objections to make all that more consistent with the style of HEAD? Please see the attached. -- Michael diff --git a/src/backend/access/transam/xlogreader.c b/src/backend/access/transam/xlogreader.c index 3ae4127b8a..c0e7c3707d