Re: Fixing the docs for ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION

2021-05-25 Thread Peter Eisentraut
On 21.05.21 22:19, Mark Dilger wrote: +ALTER SUBSCRIPTION mysubscription DROP PUBLICATION nosuchpub WITH (copy_data = false, refresh = false); +ERROR: unrecognized subscription parameter: "copy_data" +ALTER SUBSCRIPTION mysubscription SET (copy_data = false, refresh = false); +ERROR: unrecogni

Re: Fixing the docs for ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION

2021-05-23 Thread Mark Dilger
> On May 22, 2021, at 10:40 PM, Bharath Rupireddy > wrote: > > I think, for the docs part we can move the discussion to the thread > [1], if you are okay, and have the error message discussion here. > > [1] - > https://www.postgresql.org/message-id/flat/CALDaNm34qugTr5M0d1JgCgk2Qdo6LZ9UEbTB

Re: Fixing the docs for ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION

2021-05-22 Thread Bharath Rupireddy
On Sat, May 22, 2021 at 10:22 PM Mark Dilger wrote: > My concern isn't that the code is doing the wrong thing, but that the docs > and the error messages are confusing. This is particularly troubling given > that having a single action which combines the dropping of one publication > with the

Re: Fixing the docs for ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION

2021-05-22 Thread Mark Dilger
> On May 21, 2021, at 10:39 PM, Bharath Rupireddy > wrote: > > On Sat, May 22, 2021 at 1:49 AM Mark Dilger > wrote: >> >> -hackers, >> >> I think commit 82ed7748b710e3ddce3f7ebc74af80fe4869492f created some >> confusion that should be cleaned up before release. I'd like some guidance >>

Re: Fixing the docs for ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION

2021-05-21 Thread Bharath Rupireddy
On Sat, May 22, 2021 at 1:49 AM Mark Dilger wrote: > > -hackers, > > I think commit 82ed7748b710e3ddce3f7ebc74af80fe4869492f created some > confusion that should be cleaned up before release. I'd like some guidance > on what the intended behavior is before I submit a patch for this, though: > >

Fixing the docs for ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION

2021-05-21 Thread Mark Dilger
-hackers, I think commit 82ed7748b710e3ddce3f7ebc74af80fe4869492f created some confusion that should be cleaned up before release. I'd like some guidance on what the intended behavior is before I submit a patch for this, though: +ALTER SUBSCRIPTION mysubscription SET PUBLICATION nosuchpub WITH