Re: Fixing Hash Join bug I caused with adf97c156

2024-10-16 Thread David Rowley
On Wed, 16 Oct 2024 at 15:21, David Rowley wrote: > Here's a patch including a test this time. I've pushed this patch. Thanks for looking. David

Re: Fixing Hash Join bug I caused with adf97c156

2024-10-15 Thread David Rowley
On Wed, 16 Oct 2024 at 14:22, Alena Rybakina wrote: > I haven't noticed anything wrong yet. I think it's worth adding a test > to regression tests, isn't it? Here's a patch including a test this time. I had imagined that it would be hard to make the same mistake again... David v1-0001-Don-t-s

Re: Fixing Hash Join bug I caused with adf97c156

2024-10-15 Thread Alena Rybakina
Hi! On 16.10.2024 04:10, David Rowley wrote: Yesterday Andres mentioned to me that he's getting wrong results with TPCH-Q02. Andres did the analysis to figure out that this was caused by adf97c156 due to how I chose to store intermediate hash values when the Hash Join has multiple join keys. Pe

Fixing Hash Join bug I caused with adf97c156

2024-10-15 Thread David Rowley
Yesterday Andres mentioned to me that he's getting wrong results with TPCH-Q02. Andres did the analysis to figure out that this was caused by adf97c156 due to how I chose to store intermediate hash values when the Hash Join has multiple join keys. Per Andres' investigation, it seems what's going o