Re: Fix vcregress plpython3 warning

On Mon, Jan 10, 2022 at 4:14 PM Andrew Dunstan wrote: > > Pushed, and backpatched. > > Great, thanks. Regards, Juan José Santamaría Flecha

Re: Fix vcregress plpython3 warning

On 1/10/22 06:53, Juan José Santamaría Flecha wrote: > > On Mon, Jan 10, 2022 at 12:51 PM Juan José Santamaría Flecha > wrote: > > Please find attached a patch for so.  > > The patch. > >   > > Pushed, and backpatched. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.c

Re: Fix vcregress plpython3 warning

On Mon, Jan 10, 2022 at 12:51 PM Juan José Santamaría Flecha < juanjo.santama...@gmail.com> wrote: > Please find attached a patch for so. > The patch. > > Regards, > > Juan José Santamaría Flecha > v2-0001-Fix-vcregress-plpython3-warnings.patch Description: Binary data

Re: Fix vcregress plpython3 warning

On Fri, Jan 7, 2022 at 3:24 PM Andrew Dunstan wrote: > > In that case, just this should work: > > s/EXTENSION (\S*?)plpython2?u/EXTENSION $1plpython3u/g ; > > Please find attached a patch for so. I have also open an item in the commitfest: https://commitfest.postgresql.org/37/3507/ Regards, Ju

Re: Fix vcregress plpython3 warning

On Fri, Jan 7, 2022 at 3:24 PM Andrew Dunstan wrote: > > In that case, just this should work: > > s/EXTENSION (\S*?)plpython2?u/EXTENSION $1plpython3u/g ; > > LGTM. Regards, Juan José Santamaría Flecha

Re: Fix vcregress plpython3 warning

On 1/7/22 08:56, Juan José Santamaría Flecha wrote: > > On Fri, Jan 7, 2022 at 2:30 PM Andrew Dunstan wrote: > > > Yeah, this code is not a model of clarity though. I had to think > through > it and I write quite a bit of perl. I would probably write it > something > like thi

Re: Fix vcregress plpython3 warning

On Fri, Jan 7, 2022 at 2:56 PM Juan José Santamaría Flecha < juanjo.santama...@gmail.com> wrote: copy-paste > s/EXTENSION plpython2?u/EXTENSION plpython3u/g > s/EXTENSION ([^ ]*)_plpython2?u/EXTENSION $1_plpython3u/g >

Re: Fix vcregress plpython3 warning

On Fri, Jan 7, 2022 at 2:30 PM Andrew Dunstan wrote: > > Yeah, this code is not a model of clarity though. I had to think through > it and I write quite a bit of perl. I would probably write it something > like this: > > > s/EXTENSION (.*?)plpython2?u/EXTENSION $1plpython3u/g ; > > Yeah, I had to

Re: Fix vcregress plpython3 warning

On 1/7/22 07:20, Juan José Santamaría Flecha wrote: > Hi, > > When running the plcheck in Windows we get the following warning, it > is visible in the cfbots [1]: > > Use of uninitialized value $1 in concatenation (.) or string at > src/tools/msvc/vcregress.pl line 350. > >

Fix vcregress plpython3 warning

Hi, When running the plcheck in Windows we get the following warning, it is visible in the cfbots [1]: Use of uninitialized value $1 in concatenation (.) or string at src/tools/msvc/vcregress.pl line 350. This points to mangle_plpython3 subroutine. The attached patch addresses the problem. [1]