Re: Fix use of possible uninitialized variable retval (src/pl/plpgsql/src/pl_handler.c)

2024-06-05 Thread Michael Paquier
On Wed, Jun 05, 2024 at 10:27:51PM +0800, Julien Rouhaud wrote: > Note that I removed the -Werror from lapwing a long time ago, so at > least this animal shouldn't lead to hackish fixes for false positive > anymore. That's good to know. Thanks for the update. -- Michael signature.asc Descriptio

Re: Fix use of possible uninitialized variable retval (src/pl/plpgsql/src/pl_handler.c)

2024-06-05 Thread Julien Rouhaud
On Wed, Jun 5, 2024 at 1:05 PM Michael Paquier wrote: > > This complain was from lapwing, that uses a version of gcc which > produces a lot of noise with incorrect issues. It is one of the only > 32b buildfarm members, so it still has a lot of value. Note that I removed the -Werror from lapwing

Re: Fix use of possible uninitialized variable retval (src/pl/plpgsql/src/pl_handler.c)

2024-06-05 Thread Ranier Vilela
Em qua., 5 de jun. de 2024 às 02:04, Michael Paquier escreveu: > On Wed, Jun 05, 2024 at 01:12:41PM +0900, Kyotaro Horiguchi wrote: > > At Mon, 27 May 2024 11:31:24 -0300, Ranier Vilela > wrote in > >> The function *plpgsql_inline_handler* can use uninitialized > >> variable retval, if PG_TRY fa

Re: Fix use of possible uninitialized variable retval (src/pl/plpgsql/src/pl_handler.c)

2024-06-05 Thread Ranier Vilela
Em qua., 5 de jun. de 2024 às 01:12, Kyotaro Horiguchi < horikyota@gmail.com> escreveu: > At Mon, 27 May 2024 11:31:24 -0300, Ranier Vilela > wrote in > > Hi. > > > > The function *plpgsql_inline_handler* can use uninitialized > > variable retval, if PG_TRY fails. > > Fix like function*plpgsq

Re: Fix use of possible uninitialized variable retval (src/pl/plpgsql/src/pl_handler.c)

2024-06-04 Thread Michael Paquier
On Wed, Jun 05, 2024 at 01:12:41PM +0900, Kyotaro Horiguchi wrote: > At Mon, 27 May 2024 11:31:24 -0300, Ranier Vilela wrote > in >> The function *plpgsql_inline_handler* can use uninitialized >> variable retval, if PG_TRY fails. >> Fix like function*plpgsql_call_handler* wich declare retval as

Re: Fix use of possible uninitialized variable retval (src/pl/plpgsql/src/pl_handler.c)

2024-06-04 Thread Kyotaro Horiguchi
At Mon, 27 May 2024 11:31:24 -0300, Ranier Vilela wrote in > Hi. > > The function *plpgsql_inline_handler* can use uninitialized > variable retval, if PG_TRY fails. > Fix like function*plpgsql_call_handler* wich declare retval as > volatile and initialize to (Datum 0). If PG_TRY fails, retval

Fix use of possible uninitialized variable retval (src/pl/plpgsql/src/pl_handler.c)

2024-05-27 Thread Ranier Vilela
Hi. The function *plpgsql_inline_handler* can use uninitialized variable retval, if PG_TRY fails. Fix like function*plpgsql_call_handler* wich declare retval as volatile and initialize to (Datum 0). best regards, Ranier Vilela fix-use-uninitialized-retval-variable-pl_handler.patch Description: