Re: Fix unsigned output for signed values in SLRU error reporting

2022-04-06 Thread Peter Eisentraut
On 25.03.22 11:49, Pavel Borisov wrote: It's true that offset can not be negative, but printing int value as %u isn't nice even if it is not supposed to be negative. So I'd propose the small patch in this thread be applied separately if none has anything against it. committed

Re: Fix unsigned output for signed values in SLRU error reporting

2022-03-25 Thread Pavel Borisov
пн, 21 мар. 2022 г. в 16:11, Pavel Borisov : > Afaics offset etc can't be negative, so I don't think this really improves >> matters. I think there's quite a few other places where we use %u to print >> integers that we know aren't negative. >> >> If anything I think we should change the signed in

Re: Fix unsigned output for signed values in SLRU error reporting

2022-03-21 Thread Pavel Borisov
> > Afaics offset etc can't be negative, so I don't think this really improves > matters. I think there's quite a few other places where we use %u to print > integers that we know aren't negative. > > If anything I think we should change the signed integers to unsigned ones. > It > might be worth d

Re: Fix unsigned output for signed values in SLRU error reporting

2022-03-18 Thread Andres Freund
Hi, On 2022-03-18 22:52:02 +0400, Pavel Borisov wrote: > I've noticed that in SRLU error reporting both signed and unsigned values > are output as %u. I think it is worth correcting this with the very simple > patch attached. Afaics offset etc can't be negative, so I don't think this really impro

Fix unsigned output for signed values in SLRU error reporting

2022-03-18 Thread Pavel Borisov
Hi, hackers! I've noticed that in SRLU error reporting both signed and unsigned values are output as %u. I think it is worth correcting this with the very simple patch attached. Thanks! -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com