Em seg., 28 de jun. de 2021 às 00:29, Michael Paquier
escreveu:
> On Mon, Jun 28, 2021 at 10:17:55AM +1000, Peter Smith wrote:
> > IIUC for the case ALTER_SUBSCRIPTION_DROP_PUBLICATION it looks like
> > the uninitialized copy_data local stack var would remain uninitialized
> > (undefined) still a
Em dom., 27 de jun. de 2021 às 21:18, Peter Smith
escreveu:
> On Fri, Jun 25, 2021 at 11:55 PM Ranier Vilela
> wrote:
> >
> >
> >
> https://github.com/postgres/postgres/commit/3af10943ce21450e299b3915b9cad47cd90369e9
> > fixes some issues with subscriptioncmds.c, but IMHO still lack this
> issue
On Mon, Jun 28, 2021 at 10:17:55AM +1000, Peter Smith wrote:
> IIUC for the case ALTER_SUBSCRIPTION_DROP_PUBLICATION it looks like
> the uninitialized copy_data local stack var would remain uninitialized
> (undefined) still at the time it is passed at
> AlterSubscription_refresh(sub, copy_data);
Y
On Fri, Jun 25, 2021 at 11:55 PM Ranier Vilela wrote:
>
>
> https://github.com/postgres/postgres/commit/3af10943ce21450e299b3915b9cad47cd90369e9
> fixes some issues with subscriptioncmds.c, but IMHO still lack this issue.
>
I have not tested this, and gcc gave no warnings about it, but just by
vi
Em qua., 23 de jun. de 2021 às 14:38, Ranier Vilela
escreveu:
> Hi,
>
> Not per Coverity!
>
> About comments:
> 1. For drop, no "copy data"
> 2. Only refresh the added/*dropped* list of publications. (my emphasis)
>
> The documentation says:
> https://www.postgresql.org/docs/14/sql-altersubscript
Hi,
Not per Coverity!
About comments:
1. For drop, no "copy data"
2. Only refresh the added/*dropped* list of publications. (my emphasis)
The documentation says:
https://www.postgresql.org/docs/14/sql-altersubscription.html
"DROP PUBLICATION *publication_name*
Changes the list of subscribed pu
