Re: Fix some resources leaks (src/bin/pg_basebackup/pg_createsubscriber.c)

2024-04-01 Thread Ranier Vilela
Em seg., 1 de abr. de 2024 às 14:52, Tom Lane escreveu: > "Euler Taveira" writes: > > On Wed, Mar 27, 2024, at 8:50 PM, Ranier Vilela wrote: > >> Coverity has some reports in the new code > >> pg_createsubscriber.c > >> I think that Coverity is right. > > > It depends on your "right" definition.

Re: Fix some resources leaks (src/bin/pg_basebackup/pg_createsubscriber.c)

2024-04-01 Thread Tom Lane
"Euler Taveira" writes: > On Wed, Mar 27, 2024, at 8:50 PM, Ranier Vilela wrote: >> Coverity has some reports in the new code >> pg_createsubscriber.c >> I think that Coverity is right. > It depends on your "right" definition. If your program execution is ephemeral > and the leak is just before e

Re: Fix some resources leaks (src/bin/pg_basebackup/pg_createsubscriber.c)

2024-03-28 Thread Ranier Vilela
Em qua., 27 de mar. de 2024 às 23:08, Euler Taveira escreveu: > On Wed, Mar 27, 2024, at 8:50 PM, Ranier Vilela wrote: > > Coverity has some reports in the new code > pg_createsubscriber.c > I think that Coverity is right. > > > It depends on your "right" definition. > I do not think so. If your

Re: Fix some resources leaks (src/bin/pg_basebackup/pg_createsubscriber.c)

2024-03-27 Thread Euler Taveira
On Wed, Mar 27, 2024, at 8:50 PM, Ranier Vilela wrote: > Coverity has some reports in the new code > pg_createsubscriber.c > I think that Coverity is right. It depends on your "right" definition. If your program execution is ephemeral and the leak is just before exiting, do you think it's worth it

Fix some resources leaks (src/bin/pg_basebackup/pg_createsubscriber.c)

2024-03-27 Thread Ranier Vilela
Hi, Per Coverity. Coverity has some reports in the new code pg_createsubscriber.c I think that Coverity is right. 1. CID 1542682: (#1 of 1): Resource leak (RESOURCE_LEAK) leaked_storage: Variable buf going out of scope leaks the storage it points to. 2. CID 1542704: (#1 of 1): Resource leak (RE