Re: Fix port/pg_iovec.h building extensions on x86_64-darwin

2024-11-09 Thread Wolfgang Walther
Thomas Munro: Out of curiosity, is nixos deliberately using an old macOS deployment target or SDK, 10.something? I'm just wondering if our feature detection is working correctly on macOS/x86, because I'd expect real preadv/pwritev to be there from 11 onwards, and 11 is already out of support by

Re: Fix port/pg_iovec.h building extensions on x86_64-darwin

2024-11-08 Thread Nathan Bossart
On Sat, Nov 09, 2024 at 11:26:44AM +1300, Thomas Munro wrote: > Out of curiosity, is nixos deliberately using an old macOS deployment > target or SDK, 10.something? I'm just wondering if our feature > detection is working correctly on macOS/x86, because I'd expect real > preadv/pwritev to be there

Re: Fix port/pg_iovec.h building extensions on x86_64-darwin

2024-11-08 Thread Thomas Munro
On Sat, Nov 9, 2024 at 8:08 AM Wolfgang Walther wrote: > When building pg_cron [1] or pg_hll [2] for PG 17 on x86_64-darwin, we > encounter the following build failure in nixpkgs: Out of curiosity, is nixos deliberately using an old macOS deployment target or SDK, 10.something? I'm just wonderin

Re: Fix port/pg_iovec.h building extensions on x86_64-darwin

2024-11-08 Thread Nathan Bossart
On Fri, Nov 08, 2024 at 03:20:00PM -0600, Nathan Bossart wrote: > Here is a new version of the patch with an updated commit message. The > cfbot results [0] look good, so I plan to commit this one shortly unless > someone objects. Committed. -- nathan

Re: Fix port/pg_iovec.h building extensions on x86_64-darwin

2024-11-08 Thread Nathan Bossart
Here is a new version of the patch with an updated commit message. The cfbot results [0] look good, so I plan to commit this one shortly unless someone objects. [0] https://cirrus-ci.com/build/6599760059039744 -- nathan >From 5e7156defd3a169323e2bc354c3a3c4cb232fa67 Mon Sep 17 00:00:00 2001 Fro

Re: Fix port/pg_iovec.h building extensions on x86_64-darwin

2024-11-08 Thread Nathan Bossart
On Fri, Nov 08, 2024 at 08:08:06PM +0100, Wolfgang Walther wrote: > @@ -68,7 +68,7 @@ pg_preadv(int fd, const struct iovec *iov, int iovcnt, > off_t offset) > } > sum += part; > offset += part; > - if (part < iov[i].iov_len) > + if

Fix port/pg_iovec.h building extensions on x86_64-darwin

2024-11-08 Thread Wolfgang Walther
When building pg_cron [1] or pg_hll [2] for PG 17 on x86_64-darwin, we encounter the following build failure in nixpkgs: /nix/store/2clw9wg933c40f871d8iqbl909lg2yis-postgresql-17.0-dev/include/server/port/pg_iovec.h:71:12: error: comparison of integers of different signs: 'ssize_t' (aka 'long'