Re: Fix pg_buffercache document

2020-05-07 Thread Masahiko Sawada
On Fri, 8 May 2020 at 13:36, Amit Kapila wrote: > > On Thu, May 7, 2020 at 4:02 PM Amit Kapila wrote: > > > > On Thu, May 7, 2020 at 2:53 PM Masahiko Sawada > > wrote: > > > > > > > > > > > There is a typo in the patch (queris/queries). How about if slightly > > > > reword it as "Since buffer m

Re: Fix pg_buffercache document

2020-05-07 Thread Amit Kapila
On Thu, May 7, 2020 at 4:02 PM Amit Kapila wrote: > > On Thu, May 7, 2020 at 2:53 PM Masahiko Sawada > wrote: > > > > > > > > There is a typo in the patch (queris/queries). How about if slightly > > > reword it as "Since buffer manager locks are not taken to copy the > > > buffer state data that

Re: Fix pg_buffercache document

2020-05-07 Thread Amit Kapila
On Thu, May 7, 2020 at 2:53 PM Masahiko Sawada wrote: > > On Thu, 7 May 2020 at 18:12, Amit Kapila wrote: > > > > On Thu, May 7, 2020 at 2:23 PM Masahiko Sawada > > wrote: > > > > > > Hi, > > > > > > The following description in pg_buffercace is no longer true. > > > > > > When the pg_buffercach

Re: Fix pg_buffercache document

2020-05-07 Thread Masahiko Sawada
On Thu, 7 May 2020 at 18:12, Amit Kapila wrote: > > On Thu, May 7, 2020 at 2:23 PM Masahiko Sawada > wrote: > > > > Hi, > > > > The following description in pg_buffercace is no longer true. > > > > When the pg_buffercache view is accessed, internal buffer manager > > locks are taken for long enou

Re: Fix pg_buffercache document

2020-05-07 Thread Amit Kapila
On Thu, May 7, 2020 at 2:23 PM Masahiko Sawada wrote: > > Hi, > > The following description in pg_buffercace is no longer true. > > When the pg_buffercache view is accessed, internal buffer manager > locks are taken for long enough to copy all the buffer state data that > the view will display. Th

Fix pg_buffercache document

2020-05-07 Thread Masahiko Sawada
Hi, The following description in pg_buffercace is no longer true. When the pg_buffercache view is accessed, internal buffer manager locks are taken for long enough to copy all the buffer state data that the view will display. This ensures that the view produces a consistent set of results, while