Re: Fix outdated code comments in nodeAgg.c

2025-02-18 Thread Jeff Davis
On Tue, 2025-02-18 at 20:11 +0800, Zhang Mingli wrote: > Thanks for review, added it to > commitfest https://commitfest.postgresql.org/patch/5580/ Committed. Thank you! Regards, Jeff Davis

Re: Fix outdated code comments in nodeAgg.c

2025-02-18 Thread Zhang Mingli
On Feb 10, 2025 at 16:45 +0800, Richard Guo , wrote: > On Sun, Feb 9, 2025 at 11:15 PM Zhang Mingli wrote: > > By reading the codes in nodeAgg.c, I found that some comments are outdated. > > The comments referred to the function lookup_hash_entry(), which has been > > removed in commit b563594. >

Re: Fix outdated code comments in nodeAgg.c

2025-02-10 Thread Richard Guo
On Sun, Feb 9, 2025 at 11:15 PM Zhang Mingli wrote: > By reading the codes in nodeAgg.c, I found that some comments are outdated. > The comments referred to the function lookup_hash_entry(), which has been > removed in commit b563594. > I've adjusted the comments to refer to the correct function

Fix outdated code comments in nodeAgg.c

2025-02-09 Thread Zhang Mingli
Hi, By reading the codes in nodeAgg.c, I found that some comments are outdated. The comments referred to the function lookup_hash_entry(), which has been removed in commit b563594. I've adjusted the comments to refer to the correct function to make it clear. -- Zhang Mingli HashData v0-0001-f