This patch has now been waiting for author since December, with the thread
stalled. I am marking this returned with feedback for now, please feel free to
re-submit the patch to a future CF when there is renewed interest in working on
this.
--
Daniel Gustafsson
Is this feedback enough to focus the work on the right things?
I feel like Marina Polyakova pointed out some real confusing behaviour
and perhaps there's a way to solve them by focusing on one at a time
without making large changes in the code.
Perhaps an idea would be to have each module provide
On 19.11.22 20:36, Марина Полякова wrote:
Here is another set of proposed patches:
v2-0001-Fix-encoding-check-in-initdb-when-the-option-icu-.patch
Target: PG 15+
Fix encoding check in initdb when the option --icu-locale is not used:
I'm having a hard time figuring out from your examples what y
сб, 19 нояб. 2022 г. в 15:51, Peter Eisentraut
:
>
> On 19.11.22 13:12, Марина Полякова wrote:
> >> I'm not in favor of changing this. The existing code intentionally
> >> tries to centralize the "ICU is not supported in this build" knowledge
> >> in few places. Your patch tries to make this chec
On 19.11.22 13:12, Марина Полякова wrote:
I'm not in favor of changing this. The existing code intentionally
tries to centralize the "ICU is not supported in this build" knowledge
in few places. Your patch tries to make this check early, but in the
process adds more places where ICU support nee
чт, 17 нояб. 2022 г. в 09:58, Peter Eisentraut
:
>
> On 29.10.22 13:33, Marina Polyakova wrote:
> > 2. initdb/create database report problems with the ICU locale/encoding
> > although they may already report that ICU is not supported in this build:
> >
> > 2.1.
> >
> > $ initdb --locale-provider ic
чт, 17 нояб. 2022 г. в 09:54, Peter Eisentraut
:
>
> On 29.10.22 15:09, Marina Polyakova wrote:
> > On 2022-10-29 14:33, Marina Polyakova wrote:
> >> Hello!
> >>
> >> This is the last proposed patch on this subject [1] moved to a
> >> separate thread for Commitfest..
> >
> > Also added a patch to e
On 29.10.22 13:33, Marina Polyakova wrote:
2. initdb/create database report problems with the ICU locale/encoding
although they may already report that ICU is not supported in this build:
2.1.
$ initdb --locale-provider icu hoge
...
initdb: error: ICU locale must be specified
$ initdb --local
On 29.10.22 15:09, Marina Polyakova wrote:
On 2022-10-29 14:33, Marina Polyakova wrote:
Hello!
This is the last proposed patch on this subject [1] moved to a
separate thread for Commitfest..
Also added a patch to export with_icu when running src/bin/scripts tests
[1].
I have committed the
On 2022-11-12 22:43, Jose Arthur Benetasso Villanova wrote:
Hello Marina.
I just reviewed your patch.
It applied cleanly at my current master (commit
d6a3dbe14f98d867b2fc3faeb99d2d3c2a48ca67).
Also, it worked as described in email. Since it's a clarification in
an error message, I think the do
Hello Marina.
I just reviewed your patch.
It applied cleanly at my current master (commit
d6a3dbe14f98d867b2fc3faeb99d2d3c2a48ca67).
Also, it worked as described in email. Since it's a clarification in an
error message, I think the documentation is fine.
I played a bit with "make check",
Marina Polyakova
Date: Sat, 29 Oct 2022 14:25:05 +0300
Subject: [PATCH v1 2/2] Fix order of checking ICU options in initdb and create
database
First check if ICU is supported in this build. Then check that the selected
encoding is supported BY ICU (the encoding can be set from lc_ctype which ca
--
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres CompanyFrom da761095a7e39463ec6083484c4b1b924cacf387 Mon Sep 17 00:00:00 2001
From: Marina Polyakova
Date: Sat, 29 Oct 2022 14:25:05 +0300
Subject: [PATCH v1] Fix order of checking ICU options in initdb and create
database
F
13 matches
Mail list logo
