Re: Fix optimization of foreign-key on update actions

2019-03-18 Thread Peter Eisentraut
On 2019-03-11 12:57, Peter Eisentraut wrote: > On 2019-02-06 23:15, Peter Eisentraut wrote: >> On 05/02/2019 17:20, Tom Lane wrote: >>> What I *don't* like about the proposed patch is that it installs a >>> new, different comparison rule for the ON UPDATE CASCADE case only. >>> If we were to go in

Re: Fix optimization of foreign-key on update actions

2019-03-11 Thread Peter Eisentraut
;0' where a = '-0'; + +select * from pktable2; +-- buggy: did not update fktable2.x +select * from fktable2; + +drop table pktable2, fktable2; + -- -- Foreign keys and partitioned tables base-commit: f2d84a4a6b4ec891a0a52f583ed5aa081c71acc6 -- 2.21.0 From f9f05aceaed972147719345c65cce9222c50ef5e Mon Sep

Re: Fix optimization of foreign-key on update actions

2019-02-06 Thread Peter Eisentraut
On 05/02/2019 17:20, Tom Lane wrote: > What I *don't* like about the proposed patch is that it installs a > new, different comparison rule for the ON UPDATE CASCADE case only. > If we were to go in this direction, I'd think we should try to use > the same comparison rule for all FK row comparisons.

Re: Fix optimization of foreign-key on update actions

2019-02-06 Thread Peter Eisentraut
On 06/02/2019 12:23, Andrew Gierth wrote: > Two values which are sql-equal but not identical, such as two strings in > a case-insensitive collation that differ only by case, are > distinguishable in some contexts but not others, so what context > actually applies to the quoted rule? > > I think th

Re: Fix optimization of foreign-key on update actions

2019-02-06 Thread Andrew Gierth
> "Laurenz" == Laurenz Albe writes: Laurenz> Andrew Gierth wrote: >> SQL2016, 15.17 Execution of referential actions >> >> 10) If a non-null value of a referenced column RC in the referenced >> table is updated to a value that is distinct from the current value >> of RC, then, >> >>

Re: Fix optimization of foreign-key on update actions

2019-02-06 Thread Laurenz Albe
Andrew Gierth wrote: > SQL2016, 15.17 Execution of referential actions > > 10) If a non-null value of a referenced column RC in the referenced > table is updated to a value that is distinct from the current value > of RC, then, > > [snip all the stuff about how ON UPDATE actions wor

Re: Fix optimization of foreign-key on update actions

2019-02-05 Thread Tom Lane
Andrew Gierth writes: > "Peter" == Peter Eisentraut writes: > Peter> The SQL standard seems clear > (since when has the SQL standard ever been clear?) Point to Andrew ;-). However, I kind of like Peter's idea anyway on the grounds that byte-wise comparison is probably faster than invoking the

Re: Fix optimization of foreign-key on update actions

2019-02-05 Thread Andrew Gierth
> "Peter" == Peter Eisentraut writes: Peter> The SQL standard seems clear ha hahaha HAHAHAHAHAHA (since when has the SQL standard ever been clear?) SQL2016, 15.17 Execution of referential actions 10) If a non-null value of a referenced column RC in the referenced table is updated t

Fix optimization of foreign-key on update actions

2019-02-05 Thread Peter Eisentraut
rom pktable2; +select * from fktable2; + +update pktable2 set a = '0' where a = '-0'; + +select * from pktable2; +-- buggy: did not update fktable2.x +select * from fktable2; + +drop table pktable2, fktable2; + -- -- Foreign keys and partitioned tables bas